Re: test-getlogin_r is annoyingly random

2012-07-19 Thread Richard W.M. Jones
On Thu, Jul 19, 2012 at 01:04:16PM +0200, Jim Meyering wrote: > A quick workaround is to use gnulib's --avoid option > to tell it you don't want the getlogin_r tests: > > --avoid=getlogin_r-tests Thanks. I pushed this workaround upstream: https://github.com/libguestfs/libguestfs/commit/6e1b

Re: test-getlogin_r is annoyingly random

2012-07-19 Thread Jim Meyering
Richard W.M. Jones wrote: > When building in Koji (the Fedora build system), the test is usually > skipped: > > Skipping test: stdin is not a tty. > SKIP: test-getlogin_r > > except when it doesn't skip and instead it fails: > > test-getlogin_r.c:62: assertion failed > /bin/sh: line 5: 110

Re: test-getlogin_r is annoyingly random

2012-07-19 Thread Richard W.M. Jones
Here is the complete log from a failed build: http://koji.fedoraproject.org/koji/getfile?taskID=4253206&name=build.log The only other thing of note is that this is glibc 2.16-2, and it should of course already have getlogin_r so we shouldn't be using the gnulib replacement function. Rich. -- R

test-getlogin_r is annoyingly random

2012-07-19 Thread Richard W.M. Jones
When building in Koji (the Fedora build system), the test is usually skipped: Skipping test: stdin is not a tty. SKIP: test-getlogin_r except when it doesn't skip and instead it fails: test-getlogin_r.c:62: assertion failed /bin/sh: line 5: 11074 Aborted EXEEXT='' srcdir