Re: sc_prohibit_magic_number_exit false positive on string

2019-09-11 Thread Darshit Shah
* Jim Meyering [190908 17:19]: > On Sun, Sep 8, 2019 at 6:06 AM Darshit Shah wrote: > > I just realized that the syntax check rule sc_prohibit_magic_number_exit > > will > > cause a false positive when it finds the relevant tokens within a string as > > well. > > > > For example, in Wget, we hav

Re: sc_prohibit_magic_number_exit false positive on string

2019-09-08 Thread Jim Meyering
On Sun, Sep 8, 2019 at 6:06 AM Darshit Shah wrote: > I just realized that the syntax check rule sc_prohibit_magic_number_exit will > cause a false positive when it finds the relevant tokens within a string as > well. > > For example, in Wget, we have the following snippet in our tests which trips

sc_prohibit_magic_number_exit false positive on string

2019-09-08 Thread Darshit Shah
I just realized that the syntax check rule sc_prohibit_magic_number_exit will cause a false positive when it finds the relevant tokens within a string as well. For example, in Wget, we have the following snippet in our tests which trips this rule: > WGET_TEST_EXPECTED_FILES, &(wget_test_file_t []