Re: relicense module spawn-pipe

2013-08-29 Thread Eric Blake
On 08/29/2013 01:37 AM, Or Goshen wrote: > Removed the use of error() in spawn-pipe > > @@ -393,12 +394,12 @@ > create_pipe_bidi (const char *progname, >const char *prog_path, char **prog_argv, >bool null_stderr, > - bool slave_process, bo

Re: relicense module spawn-pipe

2013-08-29 Thread Richard W.M. Jones
It's easier to see your patches if you use the git send-email command. It has a long and horrible command line syntax so what people usually do is wrap it up in a shell script. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler.

Re: relicense module spawn-pipe

2013-08-29 Thread Or Goshen
Removed the use of error() in spawn-pipe On Wed, Aug 28, 2013 at 7:53 PM, Eric Blake wrote: > On 08/28/2013 08:19 AM, Or Goshen wrote: > > This patch will make the module usable from a library context, it will > not > > call error() unless specifically asked to. > > Can you please apply it to t

Re: relicense module spawn-pipe

2013-08-28 Thread Eric Blake
On 08/28/2013 08:19 AM, Or Goshen wrote: > This patch will make the module usable from a library context, it will not > call error() unless specifically asked to. > Can you please apply it to the trunk That depends on whether the patch is deemed reasonable; and if non-trivial, you may also need to

Re: relicense module spawn-pipe

2013-08-28 Thread Or Goshen
This patch will make the module usable from a library context, it will not call error() unless specifically asked to. Can you please apply it to the trunk and ask the maintainer to relicense to LGPL ? Thanks, Or On Mon, Aug 26, 2013 at 4:04 PM, Eric Blake wrote: > [please don't top-post] > >

Re: relicense module spawn-pipe

2013-08-26 Thread Eric Blake
[please don't top-post] On 08/26/2013 07:00 AM, Or Goshen wrote: > Certainly changing this behavior and rewriting it so it will return with an > error code instead of aborting would increase the usefulness of this module > ? > I'll be happy to provide a patch if that is the straw that keeps the >

Re: relicense module spawn-pipe

2013-08-26 Thread Or Goshen
Certainly changing this behavior and rewriting it so it will return with an error code instead of aborting would increase the usefulness of this module ? I'll be happy to provide a patch if that is the straw that keeps the maintainer from relaxing the license Thanks, Or On Mon, Aug 26, 2013 at

Re: relicense module spawn-pipe

2013-08-26 Thread Eric Blake
On 08/26/2013 01:27 AM, Or Goshen wrote: > hi, > > I would like to use the module spawn-pipe in a library called libguestfs to > make it compileable under mingw. currently the library is using the > fork/exec combination which doesnt compile under mingw (mingw doesnt > support fork). spawn-pipe lo

relicense module spawn-pipe

2013-08-26 Thread Or Goshen
hi, I would like to use the module spawn-pipe in a library called libguestfs to make it compileable under mingw. currently the library is using the fork/exec combination which doesnt compile under mingw (mingw doesnt support fork). spawn-pipe looks like a good replacement, however it is licensed G