Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Joël Krähemann
sorry, just didn't understand it correctly. I am going to try for the next release. On Mon, Sep 14, 2020 at 8:54 PM Bruno Haible wrote: > > Joël Krähemann wrote: > > How can I fix it in my code? > > What do you mean? Does this fix not work? >

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Bruno Haible
Joël Krähemann wrote: > How can I fix it in my code? What do you mean? Does this fix not work? Bruno

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Bruno Haible
John Darrington wrote: > I don't think this will solve all problems. > > For example if you have: > > > > #include > > struct foo > { > void write (char *); > }; > > func (struct foo *f) > { >f->write ("hello"); > } > > > > then one will get an error similar to "rpl_write is n

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Bruno Haible
Joël Krähemann wrote: > I would be interested in why it was working prior? Prior, Gnulib did '#define write rpl_write' only when - the Gnulib module 'write' was in use, either directly or indirectly, - and the platform's write() needs a workaround [1]. Now, we're doing '#define write _write'

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Joël Krähemann
How can I fix it in my code? My mingw32 compiler is $ x86_64-w64-mingw32-gcc --version x86_64-w64-mingw32-gcc (GCC) 10-posix 20200525 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Joël Krähemann
I would be interested in why it was working prior? On Sun, Sep 13, 2020 at 11:11 PM Bruno Haible wrote: > > Hi Joël, > > > Because recent gnulib has problems with read, write and close as > > struct fields. I am still using: > > > > gnulib$ git log > > commit 2d431ac35c4943a3655c07ba91870d2323321

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread Ben Pfaff
On Mon, Sep 14, 2020 at 01:54:14PM +0200, John Darrington wrote: > On Sun, Sep 13, 2020 at 11:11:55PM +0200, Bruno Haible wrote: > > > The workaround is simple: Make sure that you include the corresponding > file - > here - before the struct definition. That is, in this case

Re: recent gnulib has problems with read, write and close within structs

2020-09-14 Thread John Darrington
On Sun, Sep 13, 2020 at 11:11:55PM +0200, Bruno Haible wrote: The workaround is simple: Make sure that you include the corresponding file - here - before the struct definition. That is, in this case, at the beginning of ags/object/ags_application_context.h, add #

Re: recent gnulib has problems with read, write and close within structs

2020-09-13 Thread Joël Krähemann
thank you. On Sun, Sep 13, 2020 at 11:11 PM Bruno Haible wrote: > > Hi Joël, > > > Because recent gnulib has problems with read, write and close as > > struct fields. I am still using: > > > > gnulib$ git log > > commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master, > > origin/master,

Re: recent gnulib has problems with read, write and close within structs

2020-09-13 Thread Bruno Haible
Hi Joël, > Because recent gnulib has problems with read, write and close as > struct fields. I am still using: > > gnulib$ git log > commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master, > origin/master, origin/HEAD) > > Here is my code: > > https://git.savannah.nongnu.org/cgit/gsequ

recent gnulib has problems with read, write and close within structs

2020-09-13 Thread Joël Krähemann
Hi, Because recent gnulib has problems with read, write and close as struct fields. I am still using: gnulib$ git log commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master, origin/master, origin/HEAD) Here is my code: https://git.savannah.nongnu.org/cgit/gsequencer.git/tree/ags/object