Re: readlinkat, areadlinkat: Avoid test failures on Cygwin 3.4.6

2024-05-23 Thread Collin Funk
On 5/23/24 5:55 AM, Bruno Haible wrote: >> I just noticed in the Cygwin 32 logs that c32is* tests pass while on >> Cygwin 64 they fail. > > That's because the Cygwin 64 build is version 3.5.3, whereas the Cygwin 32 > build is version 3.3.6. Look at the 'cygcheck' output in the log. Hahaha. well th

Re: readlinkat, areadlinkat: Avoid test failures on Cygwin 3.4.6

2024-05-23 Thread Bruno Haible
Collin Funk wrote: > I just noticed in the Cygwin 32 logs that c32is* tests pass while on > Cygwin 64 they fail. That's because the Cygwin 64 build is version 3.5.3, whereas the Cygwin 32 build is version 3.3.6. Look at the 'cygcheck' output in the log. Bruno

Re: readlinkat, areadlinkat: Avoid test failures on Cygwin 3.4.6

2024-05-23 Thread Collin Funk
Hi Bruno, On 5/23/24 3:48 AM, Bruno Haible wrote: > On Cygwin 3.4.6, but not on Cygwin 3.5.3, I see these test failures: > > FAIL: test-areadlinkat.exe > FAIL: test-areadlinkat-with-size.exe > FAIL: test-readlinkat.exe > > The cause is an errno value EBADF, where EINVAL would be better. > Not wo

readlinkat, areadlinkat: Avoid test failures on Cygwin 3.4.6

2024-05-23 Thread Bruno Haible
-23 Bruno Haible readlinkat, areadlinkat: Avoid test failures on Cygwin 3.4.6. * tests/test-readlink.h (test_readlink): For an empty file name, allow errno == EBADF. * tests/test-areadlink.h (test_areadlink): Likewise. diff --git a/tests/test-areadlink.h b/tests