Re: preprocessor directive indentation, cppi

2011-02-21 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> Would you mind if I adjust whichever of the 25 in tests/ that are yours ? > > Yes, I do mind changing 160 lines of code in just one file because of this. > > My point is that 'cppi' wants to enforce a coding style that is pretty far > away from the current, reaso

Re: preprocessor directive indentation, cppi

2011-02-20 Thread Bruce Korb
On 02/20/11 16:58, Bruno Haible wrote: >> it lets you distinguish conditional and unconditional >> #include directives and #define directives based solely >> on presence or absence of spaces after the "#". > > This heuristic does not always work: > - sleep.c:# define WIN32_LEAN_AND_MEAN > is

Re: preprocessor directive indentation, cppi

2011-02-20 Thread Bruno Haible
Hi Jim, > Would you mind if I adjust whichever of the 25 in tests/ that are yours ? Yes, I do mind changing 160 lines of code in just one file because of this. My point is that 'cppi' wants to enforce a coding style that is pretty far away from the current, reasonable coding style in gnulib. It'