Re: need opendir_safer, dirent--.h

2009-11-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to James Youngman on 11/8/2009 2:59 PM: >> Here's the preliminary patch series, to be applied on top of my >> fchdir/fdopendir series. However, since we are also lacking openat_safer, it >> looks like fts will STILL pollute the standard fds.

Re: need opendir_safer, dirent--.h

2009-11-08 Thread James Youngman
On Tue, Sep 1, 2009 at 6:26 PM, Eric Blake wrote: > Eric Blake byu.net> writes: > >> > I think we need to implement opendir_safer, alongside all the other >> > *_safer modules.  Otherwise, opendir can end up placing an open directory >> > fd in one of the standard slots, and end up interfering wi

Re: need opendir_safer, dirent--.h

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/19/2009 8:17 AM: > I've tested that, with this patch, './gnulib-tool --with-tests --test > openat' no longer drags in fcntl-safer, but './gnulib-tool --with-tests > --test openat-safer' still passes the new test-openat. Ex

Re: need opendir_safer, dirent--.h

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/2/2009 1:00 PM: > And here's openat-safer, plus a rework of making fts safer. > Subject: [PATCH 2/2] backupfile, chdir-long, fts, savedir: make safer > > * lib/backupfile.c (includes): Use "dirent--.h", since > numbered_b

Re: need opendir_safer, dirent--.h

2009-09-03 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/2/2009 1:00 PM: > And here's openat-safer, plus a rework of making fts safer. Well, if I wouldn't create compilation errors in the process. > + * lib/chdir-long.c (includes): Use "fcntl--.h", since openat > + emul

Re: need opendir_safer, dirent--.h

2009-09-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/2/2009 12:55 AM: >> Here's the preliminary patch series, to be applied on top of my >> fchdir/fdopendir series. However, since we are also lacking openat_safer, it >> looks like fts will STILL pollute the standard fds.

Re: need opendir_safer, dirent--.h

2009-09-02 Thread Jim Meyering
Eric Blake wrote: > Eric Blake byu.net> writes: >> > I think we need to implement opendir_safer, alongside all the other >> > *_safer modules. Otherwise, opendir can end up placing an open directory >> > fd in one of the standard slots, and end up interfering with the intent of >> > all the other

Re: need opendir_safer, dirent--.h

2009-09-01 Thread Eric Blake
Eric Blake byu.net> writes: > > I think we need to implement opendir_safer, alongside all the other > > *_safer modules. Otherwise, opendir can end up placing an open directory > > fd in one of the standard slots, and end up interfering with the intent of > > all the other *_safer wrappers. > >

Re: need opendir_safer, dirent--.h

2009-08-28 Thread Eric Blake
> I think we need to implement opendir_safer, alongside all the other > *_safer modules. Otherwise, opendir can end up placing an open directory > fd in one of the standard slots, and end up interfering with the intent of > all the other *_safer wrappers. And here's at least one use case where i

need opendir_safer, dirent--.h

2009-08-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think we need to implement opendir_safer, alongside all the other *_safer modules. Otherwise, opendir can end up placing an open directory fd in one of the standard slots, and end up interfering with the intent of all the other *_safer wrappers. -