Re: more warnings patrol

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/30/2009 6:52 PM: >> How about moving this declaration to a new file mktime-internal.h? > > And share it between the mktime and timegm modules. Yes, that sounds nice. Done. - -- Don't work too hard, make some time for f

Re: more warnings patrol

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/30/2009 6:10 PM: > I'm committing this, to silence some unused variables, and to make > inttostr.c quiet even on older gcc. And looking in config.log, I found these. - -- Don't work too hard, make some time for fun as we

Re: more warnings patrol

2009-10-31 Thread Jim Meyering
Eric Blake wrote: > I'm committing this, to silence some unused variables, and to make > inttostr.c quiet even on older gcc. ... > diff --git a/lib/inttostr.c b/lib/inttostr.c ... > +#ifndef inttype_is_unsigned >if (i < 0) > { >do > @@ -45,6 +41,7 @@ inttostr (inttype i, char *buf)

Re: more warnings patrol

2009-10-30 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 10/30/2009 6:43 PM: > Hi Eric, > >> --- a/lib/mktime.c >> +++ b/lib/mktime.c >> @@ -147,6 +147,9 @@ const unsigned short int __mon_yday[2][13] = >> # undef __localtime_r >> # define __localtime_r localtime_r >> # define

Re: more warnings patrol

2009-10-30 Thread Bruno Haible
Hi Eric, > --- a/lib/mktime.c > +++ b/lib/mktime.c > @@ -147,6 +147,9 @@ const unsigned short int __mon_yday[2][13] = > # undef __localtime_r > # define __localtime_r localtime_r > # define __mktime_internal mktime_internal > +time_t __mktime_internal (struct tm *, > + s

more warnings patrol

2009-10-30 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm committing this, to silence some unused variables, and to make inttostr.c quiet even on older gcc. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (