link (was: mkfifoat, renameat)

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/9/2009 5:31 PM: > Meanwhile, I noticed that the link module has a bug on mingw, where link > ("a","b/.") created the regular file "b" rather than failing with ENOENT (I > noticed it because cygwin 1.5 had the same bug, and

Re: mkfifoat, renameat

2009-09-09 Thread Eric Blake
Eric Blake byu.net> writes: > Part of the problem on mingw is that the fchdir module relies on > canonicalize doing the right thing, but mingw's paths (with drive letters > and \, rather than leading / for absolute) throws canonicalize for a loop; > and cross-compilation tries to replace getcwd,

Re: mkfifoat, renameat

2009-09-08 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 9/8/2009 2:43 AM: >>> I suppose there might still be some pathological cases where renameat >>> currently fails but could be made to succeed. For example, >>> renameat(super_deep,a,root,b) will probably fail with ENAMETOOLONG when >> >> Speaking of

Re: mkfifoat, renameat

2009-09-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/8/2009 2:43 AM: >> I suppose there might still be some pathological cases where renameat >> currently fails but could be made to succeed. For example, >> renameat(super_deep,a,root,b) will probably fail with ENAMETOOLONG

Re: mkfifoat, renameat

2009-09-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/8/2009 1:50 AM: > Eric Blake wrote: >> --- a/modules/sys_stat >> +++ b/modules/sys_stat >> ... >> + -e 's|@''GNULIB_OPENAT''@|$(GNULIB_OPENAT)|g' \ > > Why this? The @GNULIB_OPENAT@ token is used only in fcnt

Re: mkfifoat, renameat

2009-09-08 Thread Jim Meyering
Eric Blake wrote: > Two more *at functions. mkfifoat is rather simple; the hardest part was > ensuring the test still compiles on mingw. renameat is more complex, > although I intentionally made it call into a helper function, at_func2, so > that I can reuse that function when I do linkat. The r

Re: mkfifoat, renameat

2009-09-08 Thread Bruno Haible
Eric Blake wrote: > --- a/modules/sys_stat > +++ b/modules/sys_stat > ... > +         -e 's|@''GNULIB_OPENAT''@|$(GNULIB_OPENAT)|g' \ Why this? The @GNULIB_OPENAT@ token is used only in fcntl.in.h, not in sys_stat.in.h. Bruno

mkfifoat, renameat

2009-09-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Two more *at functions. mkfifoat is rather simple; the hardest part was ensuring the test still compiles on mingw. renameat is more complex, although I intentionally made it call into a helper function, at_func2, so that I can reuse that function whe