Hi Simon,
On 4/24/24 6:22 AM, Simon Josefsson wrote:
> I think this was fairly common before. If there had been a 'make
> syntax-check' rule for this, we would have caught it! I have removed
> use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks.
Thanks! It showed up from some othe
On 4/24/24 11:06 AM, Bruno Haible wrote:
>> $ env GNULIB_TOOL_IMPL=py gnulib-tool --create-testdir --dir testdir1 fstatat
>> $ cd testdir1
>> $ ./configure --enable-silent-rules
>> $ make 2>&1 | grep '__STDC_WANT_LIB_EXT1__' | wc -l
>> 354
>
> I don't reproduce this. What are your CPPFLAGS and CFL
Hi Collin,
> $ env GNULIB_TOOL_IMPL=py gnulib-tool --create-testdir --dir testdir1 fstatat
> $ cd testdir1
> $ ./configure --enable-silent-rules
> $ make 2>&1 | grep '__STDC_WANT_LIB_EXT1__' | wc -l
> 354
I don't reproduce this. What are your CPPFLAGS and CFLAGS?
Bruno
Paul Eggert wrote:
> Why is telnetd.h including config.h? Only a top-level C file should
> include config.h, and it should so so at the start.
We don't have a rule that config.h should *only* be included at the
start of each compilation unit. Packages can and do include
twice.
Therefore config.
Collin Funk writes:
> Hi Paul,
>
> On 4/23/24 11:22 PM, Paul Eggert wrote:
>> Why is telnetd.h including config.h? Only a top-level C file should
>> include config.h, and it should so so at the start.
>
> I don't disagree. Most of those lines are 20 years old, so I assume it
> wasn't a problem th
Hi Paul,
On 4/23/24 11:22 PM, Paul Eggert wrote:
> Why is telnetd.h including config.h? Only a top-level C file should
> include config.h, and it should so so at the start.
I don't disagree. Most of those lines are 20 years old, so I assume it
wasn't a problem then. Though I do wonder how common
On 2024-04-23 20:50, Collin Funk wrote:
In pty.c we have:
#include
#include "telnetd.h"
in telnetd.h:
#include
Why is telnetd.h including config.h? Only a top-level C file should
include config.h, and it should so so at the start.
Hi Bruno,
On 4/19/24 3:12 PM, Bruno Haible wrote:
> The reason is that on this system, the function 'memset_s' exists in libc,
> but is only declared (in /usr/include/iso/string_iso.h) if __EXT1_VISIBLE
> is set. __EXT1_VISIBLE is defined by if
> __STDC_WANT_LIB_EXT1__ is defined to non-zero at t
t this may break programs which define errno_t and rsize_t. Such
programs will need to change, because these are now standardized types.
2024-04-19 Bruno Haible
memset_explicit: Fix compilation error on some OpenSolaris derivatives.
* m4/extensions.m4 (gl_USE_SYSTEM_EXTENSIONS): Arra
