Re: memcmp-tests module

2008-05-22 Thread Ben Pfaff
Eric Blake <[EMAIL PROTECTED]> writes: > I think that it is a bug to attach the nonnull attribute to > memcmp parameters (for the very reason that a compare of 0 > bytes should not dereference the pointer, so passing NULL is > not necessarily a bug). I am not sure that passing a null pointer to m

Re: memcmp-tests module

2008-05-22 Thread Eric Blake
Simon Josefsson josefsson.org> writes: > > It's good habit to include the tests from the autoconf macro also in the test > > suite (to verify that the autoconf macro actually did its job). So I added this: > > > > > > 2008-05-20 Bruno Haible clisp.org> > > > > * tests/test-memcmp.c (main

Re: memcmp-tests module

2008-05-20 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> The first part of this was adding a self-test for memcmp. >> I'm sure it can be improved to test more corner cases, but this is much >> better than nothing. Pushed. > > It's good habit to include the tests from the autoconf macr

Re: memcmp-tests module

2008-05-20 Thread Bruno Haible
Simon Josefsson wrote: > The first part of this was adding a self-test for memcmp. > I'm sure it can be improved to test more corner cases, but this is much > better than nothing. Pushed. It's good habit to include the tests from the autoconf macro also in the test suite (to verify that the autoc

memcmp and cross-compilation (was: Re: memcmp-tests module)

2008-05-20 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> MinGW apparently needs gnulib's memcmp module > > That was rather surprising to me, so I started investigating why that is > the case. The reason was that Autoconf's AC_FUNC_MEMCMP uses AC_RUN_IFELSE wi

memcmp-tests module (was: Re: rpl_memcmp on mingw with g++?)

2008-05-20 Thread Simon Josefsson
e corner cases, but this is much better than nothing. Pushed. /Simon >From f57b1e96a2f83183073b34a05890aa4875708301 Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[EMAIL PROTECTED]> Date: Tue, 20 May 2008 09:22:45 +0200 Subject: [PATCH] Add memcmp-tests module. --- ChangeLog