Le 25 sept. 2012 à 17:25, Stefano Lattarini a écrit :
Hi Stefano,
> Alas, this is busted for empty strings:
>
>$ cat Makefile
>equal = ...
>empty1 =
>empty2 =
>all:
> $(if $(call equal,$(emtpy1),$(empty2)),:,false)
>$ make
>false
>make: *** [all] Error 1
>
Le 25 sept. 2012 à 17:03, Jim Meyering a écrit :
> ACK.
> Only reservation is that the new name, "equal"
> may be too generic, i.e., may interfere with a
> Makefile that uses maint.mk. Maybe "_equal" instead?
I used that name. This is what I installed:
From cb38ce7db84edb421fbaeea5abe16ebeb8a
Hi Akim, Jim.
On 09/25/2012 12:32 PM, Akim Demaille wrote:
>
> Le 25 sept. 2012 à 12:11, Akim Demaille a écrit :
>
>>> Pushed.
>>
>> Well, there are several issues with the patch. I'm on it right now.
>> Do not upgrade gnulib right now.
>
> Here are the proposed fixes. I had only tested these
Akim Demaille wrote:
> Le 25 sept. 2012 à 12:11, Akim Demaille a écrit :
>
>>> Pushed.
>>
>> Well, there are several issues with the patch. I'm on it right now.
>> Do not upgrade gnulib right now.
>
> Here are the proposed fixes. I had only tested these patches
> with the various targets of the r
Le 25 sept. 2012 à 12:11, Akim Demaille a écrit :
>> Pushed.
>
> Well, there are several issues with the patch. I'm on it right now.
> Do not upgrade gnulib right now.
Here are the proposed fixes. I had only tested these patches
with the various targets of the release procedure, I had not
ant
> Pushed.
Well, there are several issues with the patch. I'm on it right now.
Do not upgrade gnulib right now.
Le 25 sept. 2012 à 11:28, Jim Meyering a écrit :
> Nice. Thanks for all of that.
Sure :)
> ACK to all three with a barely-worth-mentioning nit below.
Fixed. I also noticed I forgot the ChangeLog for the last
one. Fixed too.
Pushed.
Akim Demaille wrote:
> Le 24 sept. 2012 à 09:47, Jim Meyering a écrit :
>
>> You're welcome to leave it as is.
>
> Attached the two updated patches, and another to propagate
> the style where the body of ifeq and co. is indented.
>
>> IMHO, more important would be to remove the need to specify
>> R
Le 24 sept. 2012 à 09:47, Jim Meyering a écrit :
> You're welcome to leave it as is.
Attached the two updated patches, and another to propagate
the style where the body of ifeq and co. is indented.
> IMHO, more important would be to remove the need to specify
> RELEASE_TYPE=... for "make upload
Akim Demaille wrote:
> Hi Jim!
>
> Le 23 sept. 2012 à 16:19, Jim Meyering a écrit :
>
>>> # member-check VARIABLE,VALID-VALUES
>>> member-check = \
>>> $(if $($(1)), \
>>>$(if $(findstrin
Hi Jim!
Le 23 sept. 2012 à 16:19, Jim Meyering a écrit :
>> # member-check VARIABLE,VALID-VALUES
>> member-check = \
>> $(if $($(1)), \
>>$(if $(findstring $(_sp),$($(1))),
Akim Demaille wrote:
> Le 22 sept. 2012 à 17:02, Jim Meyering a écrit :
>
>> How about something like this?
>>
>> release-type =
>> \
>> $(subst :, ,
>> \
>>$(if $(REL
Le 22 sept. 2012 à 17:02, Jim Meyering a écrit :
> How about something like this?
>
> release-type =
> \
> $(subst :, , \
>$(if $(RELEASE_TYPE),
Akim Demaille wrote:
> Le 21 sept. 2012 à 16:44, Jim Meyering a écrit :
>
> Hi!
>
>>> diff --git a/top/maint.mk b/top/maint.mk
>>> index 87bbde9..e8ea768 100644
>>> --- a/top/maint.mk
>>> +++ b/top/maint.mk
>>> @@ -91,13 +91,22 @@ my_distdir = $(PACKAGE)-$(VERSION)
>>> # Old releases are stored he
Le 21 sept. 2012 à 16:44, Jim Meyering a écrit :
Hi!
>> diff --git a/top/maint.mk b/top/maint.mk
>> index 87bbde9..e8ea768 100644
>> --- a/top/maint.mk
>> +++ b/top/maint.mk
>> @@ -91,13 +91,22 @@ my_distdir = $(PACKAGE)-$(VERSION)
>> # Old releases are stored here.
>> release_archive_dir ?= ../
Akim Demaille wrote:
> Le 3 août 2012 à 11:41, Jim Meyering a écrit :
>
>> Akim Demaille wrote:
>>> There is still the uploading step which is not bound to a make
>>> target. I would remove the emit_upload_command completely, and
>>> instead mention the upload target in README-release, including t
Le 3 août 2012 à 11:41, Jim Meyering a écrit :
> Akim Demaille wrote:
>> There is still the uploading step which is not bound to a make target. I
>> would remove the emit_upload_command completely, and instead mention the
>> upload target in README-release, including the announcement step, WDY
Le 3 août 2012 à 11:41, Jim Meyering a écrit :
> Akim Demaille wrote:
>> There is still the uploading step which is not bound to a make target. I
>> would remove the emit_upload_command completely, and instead mention the
>> upload target in README-release, including the announcement step, WDY
Akim Demaille wrote:
> There is still the uploading step which is not bound to a make target. I
> would remove the emit_upload_command completely, and instead mention the
> upload target in README-release, including the announcement step, WDYT?
Hi Akim,
I like the added automation. Thanks.
AC
art with " GEN
>> +# announcement".
>> +@$(srcdir)/$(_build-aux)/announce-gen \
>>
> I suggest using '$(AM_V_at)' instead of '@', so that the recipe will
> show when running with "make V=1".
Excellent
Hi Akim.
On 08/03/2012 10:14 AM, Akim Demaille wrote:
>
> --- a/top/maint.mk
> +++ b/top/maint.mk
> @@ -1134,7 +1134,7 @@ sc_makefile_path_separator_check:
> # i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release)
> # and is read-only.
> writable-files:
> - if test -d $(
: Fri Aug 3 10:09:44 2012 +0200
maint.mk: improve the release procedure
* top/maint.mk (writable-files): Use $(AM_V_GEN).
(announcement): Do not.
(upload_command, upload): New.
(emit_upload_commands): Adjust.
diff --git a/ChangeLog b/ChangeLog
index a5aca2f..8304b5e
22 matches
Mail list logo
