Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Mike Frysinger
On Tuesday 29 December 2009 18:05:11 Eric Blake wrote: > Vladimir 'φ-coder/phcoder' Serbinenko gmail.com> writes: > > It's inconsistent with the rest of this file. > > That may be true, but it's not enough to worry about. i dont personally care one way or the other, but trunk gcc has sometimes

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Eric Blake
Eric Blake byu.net> writes: > but I'm inclined to not apply it. > > > It's inconsistent with the rest of this file. > > That may be true, but it's not enough to worry about. Clarification - I'm not inclined to apply it, because this is identical to upstream glibc. If you can convince Uli to

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Eric Blake
Vladimir 'φ-coder/phcoder' Serbinenko gmail.com> writes: > +#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H && HAVE_ISWCTYPE && HAVE_WCSCOLL) || defined (_LIBC) Redundant parenthesis. If we were to apply this, it should be: defined _LIBC but I'm inclined to not apply it. > It's in

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Simon Josefsson wrote: > "Vladimir 'φ-coder/phcoder' Serbinenko" writes: > > >> === modified file 'gnulib/regex_internal.h' >> --- gnulib/regex_internal.h2009-12-27 15:37:18 + >> +++ gnulib/regex_internal.h2009-12-29 22:32:31 + >> @@ -58,7 +58,7 @@ >> # define SIZE_MAX ((size_t

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Simon Josefsson
"Vladimir 'φ-coder/phcoder' Serbinenko" writes: > === modified file 'gnulib/regex_internal.h' > --- gnulib/regex_internal.h2009-12-27 15:37:18 + > +++ gnulib/regex_internal.h2009-12-29 22:32:31 + > @@ -58,7 +58,7 @@ > # define SIZE_MAX ((size_t) -1) > #endif > > -#if (defined

lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
=== modified file 'gnulib/regex_internal.h' --- gnulib/regex_internal.h2009-12-27 15:37:18 + +++ gnulib/regex_internal.h2009-12-29 22:32:31 + @@ -58,7 +58,7 @@ # define SIZE_MAX ((size_t) -1) #endif -#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H && HAVE_ISWCTYPE && H