RE: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-12 Thread YX Hao
Hi Bruno, > The dependencies to these modules (unistr/u32-strlen and unistr/u32-pcpy) are > declared in modules/fnmatch, as well as the link requirements > Could it be that > This workaround of yours disables the support of Unicode characters outside > the BMP (used by Chinese, Emoji, and many

Re: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-11 Thread Bruno Haible
YX Hao wrote: > > `c32*.c` files are newly included, but `uc_is_*` functions are not > The 2nd error also has gone with a newer gnulib commit 92cdf62b, > which is merged from the head of wget, using a hack of: > ``` > sed -i "s/!_GL_SMALL_WCHAR_T/defined _GL_SMALL_WCHAR_T/" lib/fnmatch.c This work

Re: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-10 Thread Bruno Haible
YX Hao wrote: > C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: > ../lib/libgnu.a(fnmatch.o):fnmatch.c:(.text+0x240): undefined reference to > `u32_strlen' > C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin

RE: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-10 Thread YX Hao
Hi, > `c32*.c` files are newly included, but `uc_is_*` functions are not The 2nd error also has gone with a newer gnulib commit 92cdf62b, which is merged from the head of wget, using a hack of: ``` sed -i "s/!_GL_SMALL_WCHAR_T/defined _GL_SMALL_WCHAR_T/" lib/fnmatch.c ``` https://github.com/lifenj

RE: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-10 Thread YX Hao
Hi Bruno and team, I don't use it in any other places, but only wget. Let's see the CI logs on GitHub. Requires login. I see you have an account. It uses MSYS2 + Mingw-w64 on Windows. Gnulib on commit d15237a2, but ` fnmatch.c` is the same as the latest. You can see `fnmatch.c` adopted the `u32_

Re: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-09 Thread Bruno Haible
Hi, > When I built wget for Windows, I found this error. > I guess `!_GL_SMALL_WCHAR_T` is a typo, and it should be `_GL_SMALL_WCHAR_T`. > > Line at: > https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/fnmatch.c;h=d86bc49e64b47e0f87605ccf695d74e108bdf032;hb=d1db7ef2427dce3203c2b2e55ca

lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-09 Thread YX Hao
Hi Gnulib team, When I built wget for Windows, I found this error. I guess `!_GL_SMALL_WCHAR_T` is a typo, and it should be `_GL_SMALL_WCHAR_T`. Line at: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/fnmatch.c;h=d86bc49e64b47e0f87605ccf695d74e108bdf032;hb=d1db7ef2427dce3203c2b2e5