Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-08 Thread Bruno Haible
Eric Blake wrote: > This trips a bug in mingw. There, WEOF is defined as 0x, but towlower > (0x) returns 0x77c5. This works around it. 2009-09-08 Bruno Haible Work around towlower, towupper bug on mingw. * lib/wctype.in.h (towlower, towupper) [__MINGW32__]: New r

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-08 Thread Eric Blake
Bruno Haible clisp.org> writes: > + /* Check that the tow* functions map WEOF to WEOF. */ > + ASSERT (towlower (e) == e); > + ASSERT (towupper (e) == e); This trips a bug in mingw. There, WEOF is defined as 0x, but towlower (0x) returns 0x77c5. Oddly enough, towupper(0x) wo

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-06 Thread Sergey Poznyakoff
Bruno Haible ha escrit: > Like Solaris 2.5.1 and IRIX 5.3, you mean? This should do it. Thanks, Bruno! Regards, Sergey

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-05 Thread Bruno Haible
Alan Hourihane wrote: > > > nm exclude.o | grep towlower > > > U _towlower > > > > > > And my libc doesn't define towlower() either. > > > > I see. Perhaps it is defined elsewhere? Could you please check? > > The gnulib's wchar.h does not provide a wrapper for it, unfortunately. > > Ju

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-04 Thread Sergey Poznyakoff
Hi Alan, > Sorry to ping again, but because coreutils 7.5 has the newer version of > gnulib it's blocking me from upgrading. Sorry for the delay: I was busy with other projects. I will provide a patch during this weekend. Stay in touch. Regards, Sergey

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-04 Thread Alan Hourihane
On Wed, 2009-09-02 at 13:51 +0100, Alan Hourihane wrote: > On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote: > > Alan Hourihane ha escrit: > > > > > Yes, but I get this > > > > > > nm exclude.o | grep towlower > > > U _towlower > > > > > > And my libc doesn't define towl

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-02 Thread Alan Hourihane
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > Yes, but I get this > > > > nm exclude.o | grep towlower > > U _towlower > > > > And my libc doesn't define towlower() either. > > I see. Perhaps it is defined elsewhere? Could you pleas

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > Yes, but I get this > > > > nm exclude.o | grep towlower > > U _towlower > > > > And my libc doesn't define towlower() either. > > I see. Perhaps it is defined elsewhere? Could you pleas

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > Yes, but I get this > > > > nm exclude.o | grep towlower > > U _towlower > > > > And my libc doesn't define towlower() either. > > I see. Perhaps it is defined elsewhere? Could you pleas

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Sergey Poznyakoff
Alan Hourihane ha escrit: > Yes, but I get this > > nm exclude.o | grep towlower > U _towlower > > And my libc doesn't define towlower() either. I see. Perhaps it is defined elsewhere? Could you please check? The gnulib's wchar.h does not provide a wrapper for it, unfortunately.

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Tue, 2009-09-01 at 13:10 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > exclude.c: In function 'string_hasher_ci': > > exclude.c:167: warning: implicit declaration of function 'towlower' > > exclude.c:167: warning: incompatible implicit declaration of built-in > > function '

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Sergey Poznyakoff
Alan Hourihane ha escrit: > exclude.c: In function 'string_hasher_ci': > exclude.c:167: warning: implicit declaration of function 'towlower' > exclude.c:167: warning: incompatible implicit declaration of built-in > function 'towlower' These are warnings, not errors. What errors do you get? Pleas

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Tue, 2009-09-01 at 12:30 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > Not sure this is right, but it works > > Surely it is not right. And it does not work, either: it does > not correctly lower the case of the input string. > > Have you tried the patch I sent? Your

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Tue, 2009-09-01 at 12:30 +0300, Sergey Poznyakoff wrote: > Alan Hourihane ha escrit: > > > Not sure this is right, but it works > > Surely it is not right. And it does not work, either: it does > not correctly lower the case of the input string. > > Have you tried the patch I sent? Yike

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Sergey Poznyakoff
Alan Hourihane ha escrit: > Not sure this is right, but it works Surely it is not right. And it does not work, either: it does not correctly lower the case of the input string. Have you tried the patch I sent? Regards, Sergey

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-09-01 Thread Alan Hourihane
On Thu, 2009-08-27 at 15:24 +0100, Alan Hourihane wrote: > As the subject line says, and I end up with an unresolved symbol. > > Not sure what the right definition check to wrap that up in though. Not sure this is right, but it works Alan. diff --git a/lib/exclude.c b/lib/exclude.c index 32

Re: lib/exclude.c calls towlower() without checking for wideline support

2009-08-27 Thread Sergey Poznyakoff
Alan Hourihane ha escrit: > As the subject line says, and I end up with an unresolved symbol. Please try this patch: diff --git a/lib/exclude.c b/lib/exclude.c index 32f2a0a..00f3891 100644 --- a/lib/exclude.c +++ b/lib/exclude.c @@ -31,6 +31,7 @@ #include #include #include +#include

lib/exclude.c calls towlower() without checking for wideline support

2009-08-27 Thread Alan Hourihane
As the subject line says, and I end up with an unresolved symbol. Not sure what the right definition check to wrap that up in though. Thanks, Alan.