Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Bruno Haible
Markus Gothe wrote: > Yes, taking an unsigned int in account actually fixed it... Splendid! Thanks for testing it so quickly. I've applied the patch, giving credits to Eric, since he spotted the sign-extension 3 minutes earlier than me :-) Bruno -- In memoriam Sophie Scholl

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Markus Gothe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Bruno, On 22 Feb, 2011, at 22:56 , Bruno Haible wrote: > Hi Markus, > >> Please see attached patch for ioctl() on FreeBSD and Darwin. Their definition >> differ from (int, int, ...) and the gnulib variant doesn't work well on >> 64-bit Darwin with

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Bruno Haible
Eric Blake wrote: > Maybe the real problem is that we need to ensure that our replacement > does not do sign extension. Yup, I think that's the point. > Does this patch fix your issue? > > diff --git i/lib/ioctl.c w/lib/ioctl.c > index 72f9f37..3ed4327 100644 > --- i/lib/ioctl.c > +++ w/lib/ioc

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Markus Gothe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22 Feb, 2011, at 22:53 , Eric Blake wrote: > [re-adding the list] > [please don't top-post on technical lists] > > On 02/22/2011 02:14 PM, Markus Gothe wrote: >> The issue is with PIMd-NG (http://pimd-ng.sf.net). > ... > > I'm not sure if you ema

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Bruno Haible
Hi Markus, > Please see attached patch for ioctl() on FreeBSD and Darwin. Their definition > differ from (int, int, ...) and the gnulib variant doesn't work well on > 64-bit Darwin with this proto. I'm sure this is a follow-up to this thread from January

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Eric Blake
[re-adding the list] [please don't top-post on technical lists] On 02/22/2011 02:14 PM, Markus Gothe wrote: > The issue is with PIMd-NG (http://pimd-ng.sf.net). ... I'm not sure if you emailed me privately because of sensitive content in your email, but hopefully I've trimmed enough of your conte

Re: ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Eric Blake
On 02/22/2011 12:34 PM, Markus Gothe wrote: > Please see attached patch for ioctl() on FreeBSD and Darwin. Their definition > differ from (int, int, ...) and the gnulib variant doesn't work well on > 64-bit Darwin with this proto. Can you please convince your mailer to send patches with MIME typ

ioctl-patch for Darwin and FreeBSD

2011-02-22 Thread Markus Gothe
Please see attached patch for ioctl() on FreeBSD and Darwin. Their definition differ from (int, int, ...) and the gnulib variant doesn't work well on 64-bit Darwin with this proto. //Markus - The panama-hat hacker ioctl.patch Description: Binary data PGP.sig Description: This is a digitally