James Youngman wrote:
> > On AIX 5.1, with gnulib as of today (29 March) the test-stat-time test
> > fails.
> > More precisely, on a 'jfs2' file system, the test fails in the third ASSERT
> > of test_mtime. I get these time stamps:
>
> Does the following patch fix the problem?
>
> 2007-03-30 Jam
On 3/29/07, Bruno Haible <[EMAIL PROTECTED]> wrote:
On AIX 5.1, with gnulib as of today (29 March) the test-stat-time test fails.
More precisely, on a 'jfs2' file system, the test fails in the third ASSERT
of test_mtime. I get these time stamps:
[...]
I can see two ways to fix the test:
- Turn
James Youngman wrote:
> Sorry about those defects. Thanks for cleaning up the mess :)
One more item: On AIX, there is no .
2007-03-29 Bruno Haible <[EMAIL PROTECTED]>
* tests/test-stat-time.c: Include , not .
*** tests/test-stat-time.c 27 Mar 2007 18:51:18 - 1.3
--- te
On AIX 5.1, with gnulib as of today (29 March) the test-stat-time test fails.
More precisely, on a 'jfs2' file system, the test fails in the third ASSERT
of test_mtime. I get these time stamps:
$ stat t-stt-stamp1
File: `t-stt-stamp1'
Size: 0 Blocks: 0 IO Block: 4096 r
"James Youngman" <[EMAIL PROTECTED]> writes:
> On 3/27/07, Paul Eggert <[EMAIL PROTECTED]> wrote:
>> - /* Birth time not supported. */
>> - pts->tv_sec = 0;
>> - pts->tv_nsec = 0;
>> - return 0;/* result is not valid */
>> + /* Birth time is not supported. Set tv_sec to
On 3/27/07, Paul Eggert <[EMAIL PROTECTED]> wrote:
- /* Birth time not supported. */
- pts->tv_sec = 0;
- pts->tv_nsec = 0;
- return 0;/* result is not valid */
+ /* Birth time is not supported. Set tv_sec to avoid undefined behavior. */
+ t.tv_sec = -1;
+ t.tv_nsec
Paul Eggert CS.UCLA.EDU> writes:
>
> Eric Blake byu.net> writes:
>
> > I would recommend getting rid of any test for st_spare1 or st_spare4
> > in m4/stat-time.m4.
>
> Thanks for mentioning this; I've always thought that using those
> "spare" fields was asking for trouble. I installed the f
Eric Blake <[EMAIL PROTECTED]> writes:
> I would recommend getting rid of any test for st_spare1 or st_spare4
> in m4/stat-time.m4.
Thanks for mentioning this; I've always thought that using those
"spare" fields was asking for trouble. I installed the following;
can you please check it?
> you
James Youngman <[EMAIL PROTECTED]> wrote:
> 2007-03-27 James Youngman <[EMAIL PROTECTED]>
>
>* lib/stat-time.h (get_stat_birthtime): New function for
> retrieving st_birthtime as provided by UFS2 (hence *BSD).
>* m4/stat-time.m4 (gl_STAT_BIRTHTIME): Probe for st_birthtime
Bruno Haible clisp.org> writes:
>
> James Youngman wrote:
> > this version of the patch was not tested on NetBSD-3.1 with UFS2. Sigh.
>
> But now at least you get a ready-to-use package for testing by doing
>
> ./gnulib-tool --create-testdir --dir=/tmp/testdir --with-tests stat-time
On CVS
James Youngman wrote:
> this version of the patch was not tested on NetBSD-3.1 with UFS2. Sigh.
But now at least you get a ready-to-use package for testing by doing
./gnulib-tool --create-testdir --dir=/tmp/testdir --with-tests stat-time
Transfer it to the host machine, "./configure CPPFLAGS=
Changed test_birthtime's return value to 'void', since the function falls
off without providing a return value, and since the return value is effectively
not used.
Changed NFILES from 5 to 4, to avoid using uninitialized values.
Removed the "1 || " in the test, that disabled the test_birthtime t
James Youngman wrote:
> Needs testing on everything else, notably including:
> Cygwin CVS (i.e. version 1.7 or later)
> mingw
> Systems completely lacking nanosecond timestamps
Thanks for the patch. So it can be tested by everyone easily, I applied
the patch, with trivial modific
Tested on:
Linux (ext3) (no st_birthtime support at all)
NetBSD-3.1 (UFS1) (st_birthtime support in kernel but not filesystem)
NetBSD-3.1 (UFS2) (st_birthtime support both kernel and filesystem)
NetBSD-3.1 (msdos) (st_birthtime support in kernel but not in
filesyste
14 matches
Mail list logo
