Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Bruno Haible
Hi Collin, > You have to be a bit careful with unpacking tuples: > >(a, b) = (1, 2, 3) >Traceback (most recent call last): > File "", line 1, in > ValueError: too many values to unpack (expected 2) > (a, b, _) = (1, 2, 3) > print(f'{a} {b}') > 1 2 Common Lisp, in t

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Collin Funk
Hi Bruno, On 3/29/24 4:16 AM, Bruno Haible wrote: >> I was not a fan of adding another value to the left side of this >> assignment: >> >> emit, uses_subdirs = self.emitter.lib_Makefile_am(basename, ...) > > Why not? This is perfectly normal functional programming style. > Lisp has it ("multi

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Bruno Haible
Hi Collin, > I was not a fan of adding another value to the left side of this > assignment: > > emit, uses_subdirs = self.emitter.lib_Makefile_am(basename, ...) Why not? This is perfectly normal functional programming style. Lisp has it ("multiple values"), ISO C has it ("struct" as return v

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Collin Funk
eep the GLMakefileTable > as an explicit argument. I've attached an updated patch. CollinFrom 531a82a9f9430821c83a6b310f7e5ad9644cc102 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Thu, 28 Mar 2024 18:20:24 -0700 Subject: [PATCH] gnulib-tool.py: Fix removal of variables from

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Bruno Haible
Hi Collin, > This patch fixes the extra line printed by gnulib-tool.py: > > $ diff -u test-oath-toolkit-4.out tmp758920-out > --- test-oath-toolkit-4.out 2024-03-28 13:17:54.441485990 -0700 > +++ tmp758920-out 2024-03-28 14:36:28.290120583 -0700 > @@ -194,5 +194,6 @@ >- mention "gl" in

gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Collin Funk
m 3ec8e0f47a0e0e59986c0fccef4216f26d763b2e Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Thu, 28 Mar 2024 14:33:27 -0700 Subject: [PATCH] gnulib-tool.py: Fix removal of variables from GLMakefileTable. * pygnulib/GLEmiter.py (GLEmiter.__init__): Add GLMakefileTable as a instance variable so it c