Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

Collin Funk wrote: > I've committed the attached patch. Looks good. Thanks. Bruno

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

On 5/14/24 2:24 AM, Bruno Haible wrote: > But the first line of this diagnostic looks strange, without an > indication where it comes from. Recall our conventions: > - For an error during option handling, prepend the absolute program name. > - For an error due to the contents of some files, pre

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

On 5/14/24 7:54 AM, Paul Eggert wrote: > I am still falling back on the shell implementation when I discover > gnulib-tool.py bugs or issues, and that's still happening to me (as recently > as yesterday). So Collin, if it's not too much trouble, please update > gnulib-tool.sh for this mkdir issu

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

On 2024-05-14 02:24, Bruno Haible wrote: I can do the same in gnulib-tool.sh if you would like since it should be pretty easy there too. This is not needed. The Python implementation is already the default. We haven't heard from anyone who needs to run the shell implementation. I still need to

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

Collin Funk wrote: > I've applied the attached patch. > ... > $ gnulib-tool --create-testdir --dir foo -h stdbit > not overwriting destination directory: foo > /home/collin/.local/src/gnulib/gnulib-tool.py: *** Stop. Thanks! But the first line of this diagnostic looks

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

exists, since the call is guaranteed to > overwrite configure.ac, Makefile.am, and other files. I've applied the attached patch. I can do the same in gnulib-tool.sh if you would like since it should be pretty easy there too. $ gnulib-tool --create-testdir --dir foo -h stdbit [...] execu

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

Paul Eggert wrote: > Perhaps both implementations should quickly exit in this situation, come > to think of it. I agree. I've made the same mistake a number of times. There is no valid use for continuing if $destdir already exists, since the call is guaranteed to overwrite configure.ac, Makefile.

Re: Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

On 5/13/24 7:45 PM, Paul Eggert wrote: > I messed up. However, the shell implementation of gnulib-tool diagnoses my > mistake right away, before going on its slow way: > > $ GNULIB_TOOL_IMPL=sh ./gnulib-tool --create-testdir --dir foo -h stdbit > mkdir: cannot create direct

Python './gnulib-tool --create-testdir --dir F' should quickly warn if F exists

If I run this command twice, by mistake: ./gnulib-tool --create-testdir --dir foo -h stdbit ./gnulib-tool --create-testdir --dir foo -h stdbit The second invocation eventually fails with: ... executing automake --add-missing --copy patching file build-aux/test-driver /home/eggert/src

Fix failure of 'gnulib-tool --create-testdir' with all modules

2018-10-22 Bruno Haible Fix failure of 'gnulib-tool --create-testdir' with all modules. * gnulib-tool (func_create_testdir): Exclude 'timevar' module. diff --git a/gnulib-tool b/gnulib-tool index c639f5a..3c27c8a 100755 --- a/gnulib-tool +++ b/gnulib-tool

Re: gnulib-tool --create-testdir

Hi Jim, > I tested init.sh on Solaris 10 by doing this locally, > > ./gnulib-tool --create-testdir --with-tests --dir=tt xstrtoll > > Running (in tt) ./configure && make && make dist, and copying the tarball > to the Solaris system. You don't need to

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

Eric Blake wrote: > --- a/lib/progreloc.c > +++ b/lib/progreloc.c > @@ -43,7 +43,6 @@ > # include > #endif > > -#include "canonicalize.h" > #include "relocatable.h" > > #ifdef NO_XMALLOC If you do this, the canonicalize_file_name declaration may be absent when progreloc.c is compiled, leadi

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

Eric Blake wrote: ... > Also, we need this, to pick up the change in .h file: > ... > Subject: [PATCH] canonicalize-lgpl: adjust clients to use correct header > ... > * lib/fchdir.c (includes): Use , not "canonicalize.h". Looks good. Along that line, I've added this: >From 27fc6b8b3c176038ff7216a

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/19/2009 5:16 AM: > According to Simon Josefsson on 9/19/2009 2:41 AM: >> Files: >> ... >> m4/canonicalize-lgpl.m4 > >> Bruno, Ben, is this patch the right thing? > > I'm neither, but yes, the patch is right. Sorry for no

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 9/19/2009 2:41 AM: > Files: > ... > m4/canonicalize-lgpl.m4 > > Bruno, Ben, is this patch the right thing? I'm neither, but yes, the patch is right. Sorry for not realizing I broke that when I merged the m4 file of ca

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

"emad hajjar" writes: > ./gnulib-tool: *** file /root/gnulib/./m4/canonicalize-lgpl.m4 not found > ./gnulib-tool: *** Stop. Indeed, the file does not exist but is referenced from relocatable-prog-wrapper: Files: ... m4/canonicalize-lgpl.m4 Bruno, Ben, is this patch the right thing? /Simon d