Re: gnulib-tool: Improve handling of multiple --local-dir options

2019-02-19 Thread Pavel Raiskup
On Tuesday, February 19, 2019 7:18:57 PM CET Bruno Haible wrote: > Hi Pavel, > > > > makes the IFS handling a bit more robust. > > What I meant is that > >save_IFS="$IFS" >for fpf_dir in $fpf_dirs >do > IFS="$save_IFS" > [Some more code] >done >IFS="$save_IFS" > >

Re: gnulib-tool: Improve handling of multiple --local-dir options

2019-02-19 Thread Bruno Haible
Hi Pavel, > > makes the IFS handling a bit more robust. What I meant is that save_IFS="$IFS" for fpf_dir in $fpf_dirs do IFS="$save_IFS" [Some more code] done IFS="$save_IFS" is more robust than save_IFS="$IFS" for fpf_dir in $fpf_dirs do [Some more code]

Re: gnulib-tool: Improve handling of multiple --local-dir options

2019-02-19 Thread Pavel Raiskup
Thanks for working on this, Bruno! Only nits.. On Thursday, February 14, 2019 8:53:33 PM CET Bruno Haible wrote: > [...] > This patch fixes both issues, and makes the IFS handling a bit more robust. > [...] > -case $_fpf_arg in > +case "$_fpf_arg" in > [...] > - fpf_dirs=$1 ; shift > -

gnulib-tool: Improve handling of multiple --local-dir options

2019-02-14 Thread Bruno Haible
dir of lower precendence (or Gnulib, as lowest-precedence fallback). Yes, it is even possible to have multiple .diff files that are applied one after the other. This patch fixes both issues, and makes the IFS handling a bit more robust. 2019-02-14 Bruno Haible gnulib-tool