Eric Blake wrote on 2007-08-22:
> * lib/stdio_.h (getdelim, getline): Declare.
Small improvement of the doc: Say that getline reads a line. "Return" not
"Returns" (GNU style conventions). List the identifiers in the prototype.
2007-09-29 Bruno Haible <[EMAIL PROTECTED]>
* lib/st
Eric Blake wrote:
> Here's what I'm committing; I think it addresses all your points.
>
> 2007-08-22 Eric Blake <[EMAIL PROTECTED]>
>
> Getline touchups.
> * lib/getdelim.c (getdelim): Revert regression that required *n to
> be 0 when *lineptr is NULL. Preserve errno across f
-
@@ -1,3 +1,8 @@
+2007-08-23 Simon Josefsson <[EMAIL PROTECTED]>
+
+ * lib/readline.c: Don't include getline.h, the prototype is now
+ found in stdio.h.
+
2007-08-23 Jim Meyering <[EMAIL PROTECTED]>
Getdelim touchup.
Inde
Simon Josefsson <[EMAIL PROTECTED]> wrote:
> Jim Meyering <[EMAIL PROTECTED]> writes:
>> [is this ok with you, Simon? ]
>
> Yes, please add it.
Committed.
Jim Meyering <[EMAIL PROTECTED]> writes:
> [is this ok with you, Simon? ]
Yes, please add it.
/Simon
Eric Blake <[EMAIL PROTECTED]> wrote:
> According to Eric Blake on 8/22/2007 6:04 PM:
>> According to Bruno Haible on 8/22/2007 3:02 PM:
>>> Hi Eric,
>>
>>> Thanks for working on this, and for the unit tests. The patch - excluding
>>> the one of getdelim.c - is nearly perfect. But I see three prob
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/22/2007 6:04 PM:
> According to Bruno Haible on 8/22/2007 3:02 PM:
>> Hi Eric,
>
>> Thanks for working on this, and for the unit tests. The patch - excluding
>> the one of getdelim.c - is nearly perfect. But I see three pr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/22/2007 3:02 PM:
> Hi Eric,
>
> Thanks for working on this, and for the unit tests. The patch - excluding
> the one of getdelim.c - is nearly perfect. But I see three problems:
Thanks for catching the nits. Please feel
Hi Eric,
Thanks for working on this, and for the unit tests. The patch - excluding
the one of getdelim.c - is nearly perfect. But I see three problems:
1) You define the shell variable HAVE_DECL_GETDELIM depending whether the
function exists, not whether the function is declared. But for examp
Eric Blake <[EMAIL PROTECTED]> wrote:
> 2007-08-21 Eric Blake <[EMAIL PROTECTED]>
>
> Move getline and getdelim into stdio.h, per POSIX 200x.
...
Thanks for doing that.
I've adjusted coreutils accordingly:
http://git.sv.gnu.org/gitweb/?p=coreutils.git
Eric Blake <[EMAIL PROTECTED]> writes:
> According to Jim Meyering on 8/19/2007 2:18 PM:
>> Eric Blake <[EMAIL PROTECTED]> wrote:
>>> I could go either way, although I'm leaning toward doing it now;
>>
>> I agree. Doing it now is fine.
>
> How about this for the patch, then? Simon, this is your
t detects that
it needs to malloc more than SSIZE_MAX bytes.
2007-08-21 Eric Blake <[EMAIL PROTECTED]>
Move getline and getdelim into stdio.h, per POSIX 200x.
* modules/getline (Files): Remove getline.h.
(Depends-on): Add stdio.
(configure.ac): Add module indic
Eric Blake <[EMAIL PROTECTED]> wrote:
> I could go either way, although I'm leaning toward doing it now;
I agree. Doing it now is fine.
Eric Blake <[EMAIL PROTECTED]> writes:
> I could go either way, although I'm leaning toward doing it now; I'll wait
> for anyone else to speak their mind.
I also lean towards doing it now, since I think it unlikely that
POSIX will change much before becoming official in this area,
and anyway its
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/18/2007 4:36 PM:
> Eric Blake wrote:
>> Now that POSIX 200x is standardizing getline and getdelim as part of
>> , should we get rid of getline.h and beef up stdio_.h, then
>> adjust all the callers
Eric Blake wrote:
> Now that POSIX 200x is standardizing getline and getdelim as part of
> , should we get rid of getline.h and beef up stdio_.h, then
> adjust all the callers (such as yesno.c) to assume this?
Hmm, can't we wait until the POSIX standard with these changes is offic
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Now that POSIX 200x is standardizing getline and getdelim as part of
, should we get rid of getline.h and beef up stdio_.h, then
adjust all the callers (such as yesno.c) to assume this?
- --
Don't work too hard, make some time for fun as well!
Bruno Haible <[EMAIL PROTECTED]> writes:
> Hi Simon,
>
> May I add comments to getline.h?
I suppose this has the same issue as the fix in getdelim.h.
> And also in getline.c, add the specification header before the others, to
> verify it's self-contained.
No
Hi Simon,
May I add comments to getline.h?
And also in getline.c, add the specification header before the others, to
verify it's self-contained.
Bruno
*** gnulib-20060430/lib/getline.h 2005-08-02 11:33:30.0 +0200
--- gnulib-20060430-modified/lib/getline.h 2006-05-01
19 matches
Mail list logo
