Re: getline: protect prototype better

2005-08-23 Thread Bruno Haible
Simon Josefsson wrote: > This was also discovered while porting GNU SASL to uClinux. > > Perhaps I should investigate how difficult it would be to make uClinux > run ./configure properly instead of maintaining the HAVE_* symbols > manually. Definitely. uClinux has a shell and a compilation environ

Re: getline: protect prototype better

2005-08-23 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> This was also discovered while porting GNU SASL to uClinux. >> >> Perhaps I should investigate how difficult it would be to make uClinux >> run ./configure properly instead of maintaining the HAVE_* symbols >> manually. > > Defin

Re: getline: protect prototype better

2005-08-23 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> How about this? If for some reason HAVE_DECL_GETLINE is not defined >> at all, the header file fail to parse. > > What's the point in trying to use lib/getline.c without m4/getline.m4 ? > We engage ourselves to maintain both in

Re: [bug-gnulib] getline: protect prototype better

2005-08-23 Thread Bruno Haible
Simon Josefsson wrote: > How about this? If for some reason HAVE_DECL_GETLINE is not defined > at all, the header file fail to parse. What's the point in trying to use lib/getline.c without m4/getline.m4 ? We engage ourselves to maintain both in sync, since they are part of a single gnulib module

Re: getline: protect prototype better

2005-08-23 Thread Jim Meyering
]> > > * getline.h (getline): Protect prototype better. > > --- getline.h 17 Jul 2005 11:39:14 +0200 1.16 > +++ getline.h 23 Aug 2005 13:28:13 +0200 > @@ -23,6 +23,6 @@ > # include > # include > > -#if !HAVE_DECL_GETLINE > +#if defined(HAVE_DECL_GETLINE

Re: getline: protect prototype better

2005-08-23 Thread Ben Pfaff
]> > > * getline.h (getline): Protect prototype better. > > --- getline.h 17 Jul 2005 11:39:14 +0200 1.16 > +++ getline.h 23 Aug 2005 13:28:13 +0200 > @@ -23,6 +23,6 @@ > # include > # include > > -#if !HAVE_DECL_GETLINE > +#if defined(HA

getline: protect prototype better

2005-08-23 Thread Simon Josefsson
How about this? If for some reason HAVE_DECL_GETLINE is not defined at all, the header file fail to parse. This uses the idiom that is suggested by the autoconf manual. 2005-08-23 Simon Josefsson <[EMAIL PROTECTED]> * getline.h (getline): Protect prototype better. --- getline.