> Subject: Re: gawk regex stuff you may want
> To: Aharon Robbins
> Cc: bug-gnulib@gnu.org
> From: Paul Eggert
> Date: Sun, 24 Jan 2016 00:58:28 -0800
>
> Aharon Robbins wrote:
> > I think you mean ! _LIBC && RE_ENABLE_I18N.
>
> Thanks, I installed
Aharon Robbins wrote:
I think you mean ! _LIBC && RE_ENABLE_I18N.
Thanks, I installed it with that change to the commit message.
Hi Paul.
> As far as 'grep' is concerned, it'll trust what regcomp does here, so we
> do have some freedom to change the code in this area. However, it looks
> to me like your patch would do the wrong thing for unibyte locales where
> btowc (b) returns a value that neither b nor WEOF. Also, the
On 01/20/2016 11:59 AM, Aharon Robbins wrote:
I don't see that. In regex.h:
| struct re_pattern_buffer
| {
| /* Space that holds the compiled pattern. It is declared as
| `unsigned char *' because its elements are sometimes used as
| array indexes. */
| unsigned char *__REPB_PRE
Hi Paul.
> Here are comments on the parts of the diff not incorporated in this round:
>
> > -static const char __re_error_msgid[] =
> > +static const char __re_error_msgid[] attribute_hidden =
>
> Since the constant is static, there should be no need for attribute_hidden,
> as
> the constant is
Aharon Robbins wrote:
Attached is a diff with bits and pieces (fixes / changes) in gawk's
regex routines that you may wish to apply to the GNULIB version.
Thanks for doing all that. I looked over that diff and installed the attached
patches into gnulib; they are taken from your diff.
Here a
Hi.
Attached is a diff with bits and pieces (fixes / changes) in gawk's
regex routines that you may wish to apply to the GNULIB version.
Much of this is cosmetic, but there are a few substantial fixes as well.
I *may* have already sent this to you, but I'm not sure, so I'm resending
just in case
