Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Richard W.M. Jones
On Wed, Mar 07, 2018 at 03:23:10PM +, Daniel P. Berrangé wrote: > On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote: > > On 03/05/2018 01:25 PM, Paul Eggert wrote: > > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: > > > > Yes, this worked on rawhide when I tested with libvirt. >

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote: > On 03/05/2018 01:25 PM, Paul Eggert wrote: > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: > > > Yes, this worked on rawhide when I tested with libvirt. > > > > Thanks, I installed it into Gnulib since it was breaking builds. Brun

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Eric Blake
On 03/05/2018 01:25 PM, Paul Eggert wrote: On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: Yes, this worked on rawhide when I tested with libvirt. Thanks, I installed it into Gnulib since it was breaking builds. Bruno's the expert here, and perhaps he can come up with something better. It

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Paul Eggert
On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: Yes, this worked on rawhide when I tested with libvirt. Thanks, I installed it into Gnulib since it was breaking builds. Bruno's the expert here, and perhaps he can come up with something better.

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
On Mon, Mar 05, 2018 at 11:00:40AM -0800, Paul Eggert wrote: > On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: > > I'm curious why we're trying to replace fseeko impl at all, since I > > would expect the modern glibc impl to be suitable to use as-is. > > It's to work around glibc bug#12799, a lo

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Paul Eggert
On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: I'm curious why we're trying to replace fseeko impl at all, since I would expect the modern glibc impl to be suitable to use as-is. It's to work around glibc bug#12799, a longstanding bug with ungetc and fflush. See the bug-gnulib thread that s

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
On Mon, Mar 05, 2018 at 12:19:24PM +, Daniel P. Berrangé wrote: > Fedora rawhide has just upgraded to the latest glibc git master snapshot, > of what will become the 2.28 release, and this has exposed bugs in gnulib's > fseeko.c implementation (and probably more macros) besides. > > The issue

fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
Fedora rawhide has just upgraded to the latest glibc git master snapshot, of what will become the 2.28 release, and this has exposed bugs in gnulib's fseeko.c implementation (and probably more macros) besides. The issue starts are line 50: http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fs