> I'm applying this fixup.
Oops, you were quicker. Thanks.
Bruno
Eric Blake wrote:
> But it looks like your patch didn't quite fix things either - by moving
> the lone call to AC_LIBOBJ([fpurge]) inside the ac_cv_func_fpurge = yes
> block, you are failing to compile fpurge.c when __fpurge exists but not
> fpurge.
This situation occurs precisely on glibc systems
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/16/2009 8:32 AM:
> But it looks like your patch didn't quite fix things either - by moving
> the lone call to AC_LIBOBJ([fpurge]) inside the ac_cv_func_fpurge = yes
> block, you are failing to compile fpurge.c when __fpurge
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/16/2009 6:58 AM:
>> + if test "$REPLACE_FPURGE$HAVE_DECL_FPURGE" != 01; then
>> +AC_LIBOBJ([fpurge])
>> + fi
>
> This is not right: When REPLACE_FPURGE = 0 and HAVE_DECL_FPURGE = 0, it is not
> needed to compile fp
Eric Blake wrote:
> + /* Discard the buffered 'h', leaving position at EOF. */
>ASSERT (fpurge (fp) == 0);
> + ASSERT (getc (fp) == EOF);
The file position after fpurge was not specified so far. I'm adding a check of
the file position after fpurge, not only when discarding input but also wh
Hi Eric,
Great work, this testcase!
> If this invariant is not fulfilled and the stream is read-write but
> - currently writing, subsequent putc or fputc calls will write directly
> + currently reading, subsequent putc or fputc calls will write directly
> into the buff
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/15/2009 5:26 PM:
> According to Eric Blake on 8/15/2009 1:03 PM:
>>> That means that blindly compiling the replacement fpurge.o is now a waste
>>> on Cygwin (it is still necessary for BSD, where fpurge is broken;
I've now
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/15/2009 1:03 PM:
>> That means that blindly compiling the replacement fpurge.o is now a waste
>> on Cygwin (it is still necessary for BSD, where fpurge is broken; for
>> glibc, where it is spelled __fpurge and lacks a retur
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 7/14/2009 7:18 AM:
> Cygwin 1.7 now provides fpurge, and it passes test-fpurge.c without the
> use of a wrapper function. Therefore, I think that it avoids the BSD bug
> reported here:
> http://lists.gnu.org/archive/html/bug
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Cygwin 1.7 now provides fpurge, and it passes test-fpurge.c without the
use of a wrapper function. Therefore, I think that it avoids the BSD bug
reported here:
http://lists.gnu.org/archive/html/bug-gnulib/2007-04/msg00277.html
That means that blindly
10 matches
Mail list logo
