Re: endian: Quote variables that may be undefined (regr. 2024-05-18).

2024-05-30 Thread Bruno Haible
Hi Collin, > However, as > you mention it makes simple mistakes like typos go unnoticed. Thanks for > explaining the conventions. Thanks for being willing to listen. Yes, we have to make trade-offs that are initially not obvious. Some of it (like how to avoid typo mistakes) is a years-long exper

Re: endian: Quote variables that may be undefined (regr. 2024-05-18).

2024-05-30 Thread Collin Funk
Hi Bruno, Bruno Haible writes: >> I've attached this patch fixing it. > > The patch overshoots the goal. Namely, if one systematically uses > double-quotes > for every variable access, it is harder to notice typos and copy&paste > mistakes > (which are not unfrequent in Gnulib, because we have

Re: endian: Quote variables that may be undefined (regr. 2024-05-18).

2024-05-30 Thread Bruno Haible
Hi Collin, > While learning m4/autoconf I seemed to forget about the importance of > quoting variables (see a similar issue Paul fixed with my byteswap.m4 > changes)... > > In a testdir on an AIX machine (cfarm111) I see this warning: > > ./configure[7173]: test: argument expected > ./co

endian: Quote variables that may be undefined (regr. 2024-05-18).

2024-05-30 Thread Collin Funk
29 -0700 Subject: [PATCH] endian: Quote variables that may be undefined (regr. 2024-05-18). * m4/endian_h.m4 (gl_ENDIAN_H): Quote variables that are undefined on some systems or may be defined by the user. --- ChangeLog | 6 ++ m4/endian_h.m4 | 12 ++-- 2 files changed, 12 insertio