Re: Avoid false error close_used_without_requesting_gnulib_module_close

2024-07-24 Thread Bruno Haible
--- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2024-07-24 Bruno Haible + Avoid false gethostname_used_without_requesting_gnulib_module_gethostname. + * modules/gethostname (configure.ac): Invoke gl_MODULE_INDICATOR. + * lib/unistd.in.h (gethostname): Don't define to + gethostname_used_wi

Avoid false error close_used_without_requesting_gnulib_module_close

2024-07-24 Thread Bruno Haible
A gettext bug report <https://savannah.gnu.org/bugs/?65958> found that GNU gettext, when compiled on mingw with builddir = srcdir, produces a compilation error due to the symbol 'close_used_without_requesting_gnulib_module_close'. What happens, is that: * Under the s

Re: close_used_without_requesting_gnulib_module_close

2009-08-11 Thread Bruno Haible
With this fix in place, the previous fix from 2009-07-19 [1] is not needed any more. Only tests that open sockets need to depend on 'close'. I'm applying this: [1] http://lists.gnu.org/archive/html/bug-gnulib/2009-07/msg00054.html 2009-08-11 Bruno Haible * modules/dup2-tests (Depends

Re: close_used_without_requesting_gnulib_module_close

2009-08-10 Thread Bruno Haible
NULIB_ACCEPT@) > # undef close > # define close close_used_without_requesting_gnulib_module_close > #elif defined GNULIB_POSIXCHECK > > was not considered safe (?), but I would like to have something like > this indeed. The 'accept' function does not need to be used as a trigger, since it turns an alre

Re: close_used_without_requesting_gnulib_module_close

2009-08-10 Thread Sam Steingold
; @@ -137,7 +137,7 @@ >  #  define close rpl_close >  extern int close (int); >  # endif > -#elif @UNISTD_H_HAVE_WINSOCK2_H@ > +#elif @UNISTD_H_HAVE_WINSOCK2_H@ &&(@GNULIB_SOCKET@ || @GNULIB_ACCEPT@) >  # undef close >  # define close close_used_without_requesting_gnulib

Re: close_used_without_requesting_gnulib_module_close

2009-08-10 Thread Paolo Bonzini
close # define close close_used_without_requesting_gnulib_module_close #elif defined GNULIB_POSIXCHECK was not considered safe (?), but I would like to have something like this indeed. Paolo

close_used_without_requesting_gnulib_module_close

2009-08-10 Thread Sam Steingold
What does this mean? I did not request the close module, and it is not clear why I should. (in fact, I don't see why pulling uname should change the semantics of close. yes, uname requires gethostname, which requires sockets &c, so I see the dependency chain, but I think what I see is a dependen

close_used_without_requesting_gnulib_module_close

2009-07-19 Thread Bruno Haible
ction `close_used_without_requesting_gnulib_module_close' mv -f .deps/test-binary-io.Tpo .deps/test-binary-io.Po gcc -mno-cygwin -O2 -g -mno-cygwin -L/usr/local/mingw/lib -o test-binary-io.exe test-binary-io.o ../gllib/libgnu.a test-binary-io.o: In function `main': /home/bruno/testdi