Re: clang's Undefined Sanitizer

2017-08-27 Thread Bruno Haible
Hi Benno, > > Can you confirm that you can use a newer GCC on Haiku, and that therefore > > said > > change was not actually needed? > > I couldn't find it on the site of Haiku, but finally found on the ffmpeg > site that one can get a newer gcc (5.4.0 at the moment) on Haiku by making > sure th

Re: clang's Undefined Sanitizer

2017-08-27 Thread Benno Schulenberg
Op 24-08-2017 om 11:34 schreef Bruno Haible: This part of the patch: [...] discards your change http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=e29357c8f445320cb3084352579fb2648cce4d0f I haven't gotten any answer to my inquiries https://lists.gnu.org/archive/html/bug-gnulib

Re: clang's Undefined Sanitizer

2017-08-27 Thread Bruno Haible
Paul Eggert wrote: > looking at the symptoms I > installed the attached patch into Gnulib. I hope this fixes it. Thanks, I confirm the patch fixes it (on both mingw and msvc). Bruno

Re: clang's Undefined Sanitizer

2017-08-24 Thread Paul Eggert
Bruno Haible wrote: ../gllib/libgnu.a(glob.o): In function `rpl_glob': /home/bruno/testdir-glob/build-mingw32/gllib/../../gllib/glob.c:538: undefined reference to `rpl_glob_pattern_p' Thanks, I don't have easy access to MS-Windows, but looking at the symptoms I installed the attached patch in

Re: clang's Undefined Sanitizer

2017-08-24 Thread Bruno Haible
Hi Paul, With the newest glob, a testdir of the 'glob' module fails to compile on native Windows (mingw and MSVC), with the same link error. ../gllib/libgnu.a(glob.o): In function `rpl_glob': /home/bruno/testdir-glob/build-mingw32/gllib/../../gllib/glob.c:538: undefined reference to `rpl_glob_pa

Re: clang's Undefined Sanitizer

2017-08-24 Thread Benno Schulenberg
Hi Bruno, Op 24-08-2017 om 11:34 schreef Bruno Haible: [...] discards your change http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=e29357c8f445320cb3084352579fb2648cce4d0f I haven't gotten any answer to my inquiries https://lists.gnu.org/archive/html/bug-gnulib/2017-07/msg9

Re: clang's Undefined Sanitizer

2017-08-24 Thread Bruno Haible
Hi Paul, This change @@ -1780,8 +1627,7 @@ glob_in_dir (const char *pattern, const char *directory, int flags, while (1) { struct globnames *old = names; - size_t i; - for (i = 0; i < cur; ++i) + for (size_t i = 0; i <

Re: clang's Undefined Sanitizer

2017-08-24 Thread Bruno Haible
Hi Benno, Paul Eggert writes: > With that in mind I attempted to merge that patchset into > Gnulib by installing the attached. This part of the patch: @@ -190,11 +175,8 @@ convert_dirent (const struct dirent *source) struct readdir_result result = { NULL, }; return result; }

Re: clang's Undefined Sanitizer

2017-08-23 Thread Paul Eggert
s): Add +lib/glob_internal.h, + lib/glob_pattern_p.c, lib/globfree.c. + (Depends-on): Remove snippet/arg-nonnull. + 2017-08-22 Paul Eggert glob: port to clang's Undefined Sanitizer diff --git a/lib/flexmember.h b/lib/flexmember.h index c71ea6510..ceca74c2c 100644 --- a/lib/flexmember.h +++ b/l

Re: clang's Undefined Sanitizer

2017-08-23 Thread Tim Rühsen
patch into Gnulib to try to fix this. > I hope it is enough to pacify clang's Undefined Sanitizer. If not, Tim, > please let us know, and thanks for reporting the problem. Thanks for the patch ! I confirm that the sanitizer doesn't trigger any more with the latest gnulib. Reg

Re: clang's Undefined Sanitizer

2017-08-22 Thread Adhemerval Zanella
On 22/08/2017 18:34, Paul Eggert wrote: > On 08/22/2017 10:39 AM, Adhemerval Zanella wrote: >> In fact I decided to *not* sync flexmember because with >> following patch I intend to send (which are in the original thread) >> make flexmember unnecessary. > > I see that you sent these proposed pat

Re: clang's Undefined Sanitizer

2017-08-22 Thread Paul Eggert
On 08/22/2017 10:39 AM, Adhemerval Zanella wrote: In fact I decided to *not* sync flexmember because with following patch I intend to send (which are in the original thread) make flexmember unnecessary. I see that you sent these proposed patches to glibc glob in the thread starting here: htt

Re: clang's Undefined Sanitizer

2017-08-22 Thread Adhemerval Zanella
ry to fix this. I > hope it is enough to pacify clang's Undefined Sanitizer. If not, Tim, please > let us know, and thanks for reporting the problem. > > I'll CC: this to Adhemerval Zanella, who's working on porting Gnulib glob.c > back to glibc, as I worry that th

Re: clang's Undefined Sanitizer

2017-08-22 Thread Paul Eggert
On 08/22/2017 09:49 AM, Bruno Haible wrote: It obviously does not handle the 'struct globnames' allocated with the FLEXSIZEOF macro (lines 1719..1732). Yes, and I installed the attached patch into Gnulib to try to fix this. I hope it is enough to pacify clang's Undefined Sa

Re: clang's Undefined Sanitizer

2017-08-22 Thread Bruno Haible
[Changing the subject, as this is an unrelated topic.] Hi Tim, > I also see several false positives from clang's Undefined Sanitizer due to > alloca 'magic' (reallocations on stack space ?). This might not be directly > related, but I think there is a common coding patt