Hi Collin,
> I never looked at the check-module script until now. Was it supposed
> to be used as an automatic check to be run before committing or
> something?
Probably yes. Certainly Jim used it. I don't use it.
Bruno
I never looked at the check-module script until now. Was it supposed
to be used as an automatic check to be run before committing or
something?
I noticed that it doesn't handle conditional dependencies like this:
Dependencies:
stat[test $NEED_STAT_PLEASE = 1]
This
There are still plenty of violations, but this removes a few false-positives.
* check-module (%exempt_header): Add exception for some
conditionally-included headers.
Index: check-module
===
RCS file: /sources/gnulib
Checking openat produced this:
$ cd modules && ../check-module openat
check-module: ../lib/openat.c: duplicate inclusion of at-func.c
check-module: ../lib/openat.c: duplicate inclusion of at-func.c
So I fixed it:
* check-module (find_included_lib_files): Add at-func.
I installed this, so that findutils would bootstrap:
2006-08-15 Paul Eggert <[EMAIL PROTECTED]>
* modules/cycle-check (configure.ac): Add gl_CYCLE_CHECK.
--- modules/cycle-check 10 Aug 2006 13:40:17 - 1.6
+++ modules/cycle-check 15 Aug 2006 21:46:42 -
@@ -12,6 +12,7 @@ sam
Hello,
On Mon, Jul 11, 2005 at 02:38:23PM +0200, Stepan Kasal wrote:
> 2005-07-11 Bruno Haible <[EMAIL PROTECTED]>
> and Stepan Kasal <[EMAIL PROTECTED]>
>
> * check-module: If more parameters are given, check each of them
> separately; add more
Hello,
about two weeks ago I submitted a patch
http://lists.gnu.org/archive/html/bug-gnulib/2005-07/msg00084.html
I verified that the archive hasn't clobbered it, except the first
two lines:
2005-07-11 Bruno Haible <[EMAIL PROTECTED]>
and Stepan Kasal <[EMAIL PROTECTED]>
Could any of
Hello,
On Mon, Jul 11, 2005 at 01:30:32PM +0200, Bruno Haible wrote:
> > (cd modules; ../check-module *)
...
> There seems to be a portability problem with the check-module script:
actually, the script didn't seem to be prepared for such usage at all.
It seems that the script ac
Jim Meyering wrote:
> FYI, I ran this command
>
> (cd modules; ../check-module *)
>
> and saw some new warnings:
There seems to be a portability problem with the check-module script:
When I remove all the exceptions code from the check-module script and run
(cd modules; ../ch