Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Mon, 10 Dec 2012 14:52:52 -0800 > From: Paul Eggert > CC: m...@netris.org, br...@clisp.org, bug-gnulib@gnu.org > > On 12/09/12 22:31, Eli Zaretskii wrote: > > Ping! Could someone please commit this? TIA. > > I just now did that. Thanks for the patch. Thanks!

Re: canonicalize_file_name does not support MS-Windows style file names

On 12/09/12 22:31, Eli Zaretskii wrote: > Ping! Could someone please commit this? TIA. I just now did that. Thanks for the patch.

Re: canonicalize_file_name does not support MS-Windows style file names

Ping! Could someone please commit this? TIA. > Date: Wed, 21 Nov 2012 20:31:41 +0200 > From: Eli Zaretskii > CC: m...@netris.org, br...@clisp.org, bug-gnulib@gnu.org > > I found a bug, so I'm attaching a patch to fix it. The list of test > cases is now this: > > 'foo.bar' => 'd:\usr\eli

Re: canonicalize_file_name does not support MS-Windows style file names

I found a bug, so I'm attaching a patch to fix it. The list of test cases is now this: 'foo.bar' => 'd:\usr\eli\utils\lib/foo.bar' '.\foo.bar' => 'd:\usr\eli\utils\lib/foo.bar' './foo.bar' => 'd:\usr\eli\utils\lib/foo.bar' '..\foo.bar' => 'd:\usr\eli\utils\foo.bar' '../fo

Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Tue, 20 Nov 2012 13:49:09 -0800 > From: Paul Eggert > CC: m...@netris.org, br...@clisp.org, bug-gnulib@gnu.org > > Thanks, I made some trivial changes to the patch to get it to > compile and use gnulib style and installed the following into gnulib: Thanks.

Re: canonicalize_file_name does not support MS-Windows style file names

Thanks, I made some trivial changes to the patch to get it to compile and use gnulib style and installed the following into gnulib: >From 169ed317dc19a14160656868b08f3ba409f1a87f Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Tue, 20 Nov 2012 13:47:22 -0800 Subject: [PATCH] canonicalize, cano

Re: canonicalize_file_name does not support MS-Windows style file names

> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, > RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 > Date: Tue, 20 Nov 2012 01:30:55 -0800 > From: Paul Eggert > CC: m...@netris.org, br...@clisp.org, bug-gnulib@gnu.org > > On 11/19/2012 07:46 PM, Eli Zaretsk

Re: canonicalize_file_name does not support MS-Windows style file names

On 11/19/2012 07:46 PM, Eli Zaretskii wrote: > Where are the instructions for writing log entries for gnulib? From > casual reading, it doesn't look like what standards.texi says, so I > presume there are some different rules. Should be the standard GNU style. We do use a leading single line to

Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Mon, 19 Nov 2012 14:20:23 -0800 > From: Paul Eggert > CC: Mark H Weaver , br...@clisp.org, bug-gnulib@gnu.org > > Thanks, I assume this supersedes the patch in > ? Yes, it does. > At some point we'll need a ChangeLog en

Re: canonicalize_file_name does not support MS-Windows style file names

Thanks, I assume this supersedes the patch in ? At some point we'll need a ChangeLog entry for it -- perhaps someone (not necessarily you) can volunteer to write one.

Re: canonicalize_file_name does not support MS-Windows style file names

> From: Mark H Weaver > Cc: Paul Eggert , br...@clisp.org, bug-gnulib@gnu.org > Date: Wed, 07 Nov 2012 22:49:36 -0500 > > Eli Zaretskii writes: > >> Eli, I see that Bruno asked for a set of Windows-syntax filenames to > >> extend the unit test. Would you be willing to work on that? > > > > I c

Re: canonicalize_file_name does not support MS-Windows style file names

Hi Eli, Eli Zaretskii writes: >> Eli, I see that Bruno asked for a set of Windows-syntax filenames to >> extend the unit test. Would you be willing to work on that? > > I can come up with file names that could be used to test the code, if > this will help, but I won't have resources to make a co

Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Wed, 07 Nov 2012 07:30:03 -0800 > From: Paul Eggert > CC: Eli Zaretskii , bug-gnulib@gnu.org, br...@clisp.org > > I suggest that if we don't hear from [Bruno] soon, that we apply the > patch to Gnulib. Thank you, I'd appreciate that.

Re: canonicalize_file_name does not support MS-Windows style file names

> From: Mark H Weaver > Cc: br...@clisp.org, bug-gnulib@gnu.org > Date: Wed, 07 Nov 2012 08:07:04 -0500 > > Guile needs Eli's patch in order build under mingw + msys, which is > important for several cross-platform programs that depend on libguile. > We hope to release Guile 2.0.7 in the week of

Re: canonicalize_file_name does not support MS-Windows style file names

We've mostly been relying on Bruno to review patches like that, as he has the expertise and the desire to support Windows. Unfortunately Bruno has been busy lately. I suggest that if we don't hear from him soon, that we apply the patch to Gnulib. Guile can do that now to its copy of lib/canonical

Re: canonicalize_file_name does not support MS-Windows style file names

Hi, Guile needs Eli's patch in order build under mingw + msys, which is important for several cross-platform programs that depend on libguile. We hope to release Guile 2.0.7 in the week of Nov 26, so it would be great if this patch could be integrated soon. Eli, I see that Bruno asked for a set o

Re: canonicalize_file_name does not support MS-Windows style file names

Ping! (6 months) > Date: Tue, 19 Jun 2012 18:55:02 +0300 > From: Eli Zaretskii > CC: bug-gnulib@gnu.org > > > Date: Tue, 17 Jan 2012 22:04:38 +0200 > > From: Eli Zaretskii > > CC: bug-gnulib@gnu.org > > > > > From: Bruno Haible > > > Bcc: br...@haible.de > > > Date: Tue, 17 Jan 2012 20:07:11

Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Tue, 19 Jun 2012 18:55:02 +0300 > From: Eli Zaretskii > CC: bug-gnulib@gnu.org > > > Date: Tue, 17 Jan 2012 22:04:38 +0200 > > From: Eli Zaretskii > > CC: bug-gnulib@gnu.org > > > > > From: Bruno Haible > > > Bcc: br...@haible.de > > > Date: Tue, 17 Jan 2012 20:07:11 +0100 > > > > > >

Re: canonicalize_file_name does not support MS-Windows style file names

> Date: Tue, 17 Jan 2012 22:04:38 +0200 > From: Eli Zaretskii > CC: bug-gnulib@gnu.org > > > From: Bruno Haible > > Bcc: br...@haible.de > > Date: Tue, 17 Jan 2012 20:07:11 +0100 > > > > Thanks, I'll look into integrating it. > > Thanks, looking forward to it. > > > Do you also have a set of

Re: canonicalize_file_name does not support MS-Windows style file names

> From: Bruno Haible > Bcc: br...@haible.de > Date: Tue, 17 Jan 2012 20:07:11 +0100 > > Thanks, I'll look into integrating it. Thanks, looking forward to it. > Do you also have a set of Windows-syntax filenames available on which you > tested it? So that we can extend the unit test. I don't ha

Re: canonicalize_file_name does not support MS-Windows style file names

Hi Eli, > With the patch below, it does. Thanks, I'll look into integrating it. Do you also have a set of Windows-syntax filenames available on which you tested it? So that we can extend the unit test. Btw, this is your first major contribution to Gnulib. Would you mind starting the copyright a

canonicalize_file_name does not support MS-Windows style file names

With the patch below, it does. HTH --- lib/canonicalize-lgpl.c~0 2011-10-22 16:19:34.0 +0200 +++ lib/canonicalize-lgpl.c 2012-01-17 13:10:52.608428500 +0200 @@ -51,6 +51,7 @@ # define __realpath realpath # include "pathmax.h" # include "malloca.h" +# include "dosname.h" # if HAV