Re: bug in readutmp module

2006-01-10 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Jim Meyering wrote: >> How about if we leave the now-redundant >> AC_REQUIRE in place for now? > > Done. I committed only the other part. Thanks. I mistakenly committed the whole change earlier, but undid the mistake just now.

Re: bug in readutmp module

2006-01-10 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > The reason is that m4/readutmp.m4 invokes gl_FUNC_FREE, but m4/free.m4 is not > part of this module or its dependencies. > > Here is a fix. OK to commit? Hi Bruno! Thanks for working on this. Adding the module dependency is fine. However, I'm reluctant

Re: bug in readutmp module

2006-01-10 Thread Bruno Haible
Jim Meyering wrote: > However, I'm reluctant to remove the AC_REQUIRE, since > that would make the code+.m4 combination depend silently on > having a particular implementation of free. Yes, I understand. By looking at the source code, it's not immediately clear which free() variant is meant. > Th

bug in readutmp module

2006-01-10 Thread Bruno Haible
Jim, "gnulib-tool --create-megatestdir --dir=/dev/shm/testdir --with-tests" shows this: configure.ac:20: warning: gl_FUNC_FREE is m4_require'd but is not m4_defun'd configure.ac:20: gl_FUNC_FREE is required by... m4/readutmp.m4:55: gl_READUTMP is expanded from... The reason is that m4/readutmp.m