Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-07-04 Thread Bruno Haible
Jim Meyering wrote: > > OK to commit? > > Yes, that looks fine. Actually MacOS X and OpenBSD now also support the POSIX API (statvfs function). I've adjusted the comments as below and pushed it. --- m4/fsusage.m4 2010-07-04 23:44:29.0 +0200 +++ m4/fsusage.m42010-07-04 23:41:11.

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-07-04 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> > Upon inspection, it appears that the fu_cv_sys_stat_statfs2_bsize >> > test in m4/fsusage.m4 (labelled "AIX") would succeed on >> > glibc, MacOS X, FreeBSD, NetBSD, OpenBSD, AIX, HP-UX, Solaris, Cygwin >> > ... >> > without a clear overview of which platform e

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-07-04 Thread Bruno Haible
Hi Jim, > > Upon inspection, it appears that the fu_cv_sys_stat_statfs2_bsize > > test in m4/fsusage.m4 (labelled "AIX") would succeed on > > glibc, MacOS X, FreeBSD, NetBSD, OpenBSD, AIX, HP-UX, Solaris, Cygwin > > ... > > without a clear overview of which platform ends up using which code, > >

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> However, I'm not sure it's portable enough. >> Do you know when the f_frsize member began to be useful? >> Without knowing that, I cannot judge whether this introduces >> a portability problem on older glibc, kernels or file systems. > > There are also other platf

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Bruno Haible
Hi Jim, > However, I'm not sure it's portable enough. > Do you know when the f_frsize member began to be useful? > Without knowing that, I cannot judge whether this introduces > a portability problem on older glibc, kernels or file systems. There are also other platforms than glibc/Linux. Upon i

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Jim Meyering
Miklos Szeredi wrote: > On Wed, 16 Jun 2010, Jim Meyering wrote: >> Miklos Szeredi wrote: >> > On Thu, 03 Jun 2010, Miklos Szeredi wrote: >> >> Hmm, actually "struct statfs" on linux does have f_frsize, only the >> >> manpage doesn't document it. So correct thing would be to use that, >> >> no? >>

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Miklos Szeredi
On Wed, 16 Jun 2010, Jim Meyering wrote: > Miklos Szeredi wrote: > > On Thu, 03 Jun 2010, Miklos Szeredi wrote: > >> Hmm, actually "struct statfs" on linux does have f_frsize, only the > >> manpage doesn't document it. So correct thing would be to use that, > >> no? > > > > Here's a patch that all

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-15 Thread Jim Meyering
Miklos Szeredi wrote: > On Thu, 03 Jun 2010, Miklos Szeredi wrote: >> Hmm, actually "struct statfs" on linux does have f_frsize, only the >> manpage doesn't document it. So correct thing would be to use that, >> no? > > Here's a patch that allows df(1) to correctly calculate the disk usage > and d