Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-03-06 Thread George Valkov
> On 2023-03-06, at 9:37 AM, Paul Eggert wrote: > > I recall reading somewhere in this thread that a 'split' test was failing on > macOS because it doesn't let you lseek on /dev/null. I fixed that problem > here: > > https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=aa266f1b3dc4e12a

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-03-06 Thread Pádraig Brady
On 06/03/2023 07:37, Paul Eggert wrote: I recall reading somewhere in this thread that a 'split' test was failing on macOS because it doesn't let you lseek on /dev/null. I fixed that problem here: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=aa266f1b3dc4e12acdc46cc0f562adc03c2c0b8f

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-03-05 Thread Paul Eggert
I recall reading somewhere in this thread that a 'split' test was failing on macOS because it doesn't let you lseek on /dev/null. I fixed that problem here: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=aa266f1b3dc4e12acdc46cc0f562adc03c2c0b8f and fixed some other 'split' issues i

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-25 Thread Pádraig Brady
On 24/02/2023 23:23, George Valkov wrote: Are we in a state where I can update OpenWRT to the latest coreutils master or perhaps it would be better to wait until you fix the tests and coreutils-9.2 is released? You mentioned the release is coming soon? Probably best to wait for the 9.2 releas

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread George Valkov
> On 2023-02-25, at 12:47 AM, Pádraig Brady wrote: > > On 24/02/2023 22:06, George Valkov wrote: >> If I revert a0803c4bad6f8e11bb05effcc42ef433f4fc3f9b, the requirement to >> press enter after PASS: tests/rm/isatty.sh is fixed. > > Ah very useful info. > I'll test this on my macOS 13.2 syste

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread Pádraig Brady
On 24/02/2023 22:06, George Valkov wrote: If I revert a0803c4bad6f8e11bb05effcc42ef433f4fc3f9b, the requirement to press enter after PASS: tests/rm/isatty.sh is fixed. Ah very useful info. I'll test this on my macOS 13.2 system. Sometimes it might randomly hang: gdb after PASS: tests/rm/r-4

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread George Valkov
If I revert a0803c4bad6f8e11bb05effcc42ef433f4fc3f9b, the requirement to press enter after PASS: tests/rm/isatty.sh is fixed. Sometimes it might randomly hang: gdb after PASS: tests/rm/r-4.sh ^Cmake[1]: *** Deleting file 'tests/rm/r-root.log' ^C^C^C ps -A |grep gdb 55051 ttys0200:00.09 gdb -

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread George Valkov
> On 2023-02-24, at 5:43 PM, Pádraig Brady wrote: > > On 24/02/2023 14:33, George Valkov wrote: >>> On 2023-02-24, at 12:23 AM, Paul Eggert wrote: >>> >>> On 2/20/23 13:14, Pádraig Brady wrote: Since https://github.com/coreutils/gnulib/commit/4db8db34 gnulib has been unconditionally

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread Pádraig Brady
On 24/02/2023 14:33, George Valkov wrote: On 2023-02-24, at 12:23 AM, Paul Eggert wrote: On 2/20/23 13:14, Pádraig Brady wrote: Since https://github.com/coreutils/gnulib/commit/4db8db34 gnulib has been unconditionally replacing lseek() on macos. Now with SEEK_DATA undefined that replaced lse

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-24 Thread George Valkov
> On 2023-02-24, at 12:23 AM, Paul Eggert wrote: > > On 2/20/23 13:14, Pádraig Brady wrote: >> Since https://github.com/coreutils/gnulib/commit/4db8db34 >> gnulib has been unconditionally replacing lseek() on macos. >> Now with SEEK_DATA undefined that replaced lseek() >> will run the code inte

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-23 Thread Pádraig Brady
On 23/02/2023 22:23, Paul Eggert wrote: On 2/20/23 13:14, Pádraig Brady wrote: Since https://github.com/coreutils/gnulib/commit/4db8db34 gnulib has been unconditionally replacing lseek() on macos. Now with SEEK_DATA undefined that replaced lseek() will run the code intended for BeOS. So either t

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-23 Thread Paul Eggert
On 2/20/23 13:14, Pádraig Brady wrote: Since https://github.com/coreutils/gnulib/commit/4db8db34 gnulib has been unconditionally replacing lseek() on macos. Now with SEEK_DATA undefined that replaced lseek() will run the code intended for BeOS. So either the lseek.m4 or lseek.c needs adjusting ac

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-22 Thread George Valkov
I received an update from Apple > We reproduced the issue and are investigating. > Our engineers are investigating the root cause of the issue you reported. If > we need more information from you, we’ll add a comment and send you an email. Georgi Valkov httpstorm.com nano RTOS

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-20, at 11:14 PM, Pádraig Brady wrote: > > On 20/02/2023 19:35, George Valkov wrote: >>> On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: >>> >>> On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh >>

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread Pádraig Brady
On 20/02/2023 19:35, George Valkov wrote: On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh These look unrelated

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: > > On 20/02/2023 15:02, George Valkov wrote: >> Hi Paul, the following tests fail after your patch: >> FAIL: tests/split/filter.sh >> FAIL: tests/split/b-chunk.sh >> FAIL: tests/split/l-chunk.sh > > These look unrelated and may be due to some

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread Pádraig Brady
On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh These look unrelated and may be due to some other change in your environment. Specifically lseek() is failing on /d

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh FAIL: tests/cp/sparse-perf.sh Before patch https://httpstorm.com/share/.openwrt/test/2023-02-06_coreutils-9.1/test-05-95f4ee0577dd836de523f46999777fbbbe9d2772-o

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-19, at 8:08 AM, Paul Eggert wrote: > > George, given what you've written I suppose we should give up the idea of > copying sparse files efficiently on macOS (and on FreeBSD 13.0-RELEASE, as it > has a similar bug with SEEK_HOLE and SEEK_DATA), in cases where fclonefileat > does n

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-19 Thread Pádraig Brady
On 19/02/2023 06:08, Paul Eggert wrote: George, given what you've written I suppose we should give up the idea of copying sparse files efficiently on macOS (and on FreeBSD 13.0-RELEASE, as it has a similar bug with SEEK_HOLE and SEEK_DATA), in cases where fclonefileat does not work. Please try t

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-18 Thread Paul Eggert
George, given what you've written I suppose we should give up the idea of copying sparse files efficiently on macOS (and on FreeBSD 13.0-RELEASE, as it has a similar bug with SEEK_HOLE and SEEK_DATA), in cases where fclonefileat does not work. Please try the attached Gnulib patch; it uses your