Re: boot-time: straighten code

2023-08-16 Thread Bruno Haible
I wrote: > So, the test passes on all these platforms: > - Linux: Ubuntu 22.04, Alpine Linux > - Debian GNU/Hurd 2022 > - Debian GNU/kFreeBSD 7 > - NetBSD 9.3 > - OpenBSD 7.2 > - Cygwin 2.9.0 It passes also on Android 11, within the Termux app. (I now got past the build failure.) Brun

Re: boot-time: straighten code

2023-08-15 Thread Paul Eggert
On 2023-08-14 06:51, Bruno Haible wrote: But that is just a workaround. Is someone among the glibc people looking at the original glibc bughttps://sourceware.org/bugzilla/show_bug.cgi?id=30701 ? As far as I know, nobody is looking into it other than you and me. I think it's low priority as pe

Re: boot-time: straighten code

2023-08-15 Thread Bruno Haible
Paul Eggert wrote: > I installed the attached patch into Emacs > master, which you should be able to test via: > > git clone https://git.savannah.gnu.org/git/emacs.git > cd emacs > ./autogen.sh > ./configure > make > src/emacs > > Please give it a try, especia

Re: boot-time: straighten code

2023-08-14 Thread Bruno Haible
Andreas Schwab wrote: > >char ut_host[__UT_HOSTSIZE]; /* Hostname for remote login. */ > > That's still using reserved symbols. Fixed through the patch below. But that is just a workaround. Is someone among the glibc people looking at the original glibc bug https://sourceware.org/bugzill

Re: boot-time: straighten code

2023-08-14 Thread Andreas Schwab
On Aug 14 2023, Bruno Haible wrote: > diff --git a/lib/readutmp.h b/lib/readutmp.h > index f7cad36d44..1fbe29d86f 100644 > --- a/lib/readutmp.h > +++ b/lib/readutmp.h > @@ -142,7 +142,7 @@ struct utmpx32 >pid_t ut_pid;/* Process ID of login process. */ >char ut_line[__

Re: boot-time: straighten code

2023-08-14 Thread Bruno Haible
Andreas Schwab wrote: > >> In file included from boot-time.c:47: > >> readutmp.h:145:16: error: ‘__UT_USERSIZE’ undeclared here (not in a > >> function); did you mean ‘UT_USER_SIZE’? > >> 145 | char ut_user[__UT_USERSIZE]; /* Username. */ > >> |^ > >>

Re: boot-time: straighten code

2023-08-14 Thread Andreas Schwab
On Aug 14 2023, Bruno Haible wrote: > Andreas Schwab wrote: >> In file included from boot-time.c:47: >> readutmp.h:145:16: error: ‘__UT_USERSIZE’ undeclared here (not in a >> function); did you mean ‘UT_USER_SIZE’? >> 145 | char ut_user[__UT_USERSIZE]; /* Username. */ >> |

Re: boot-time: straighten code

2023-08-14 Thread Bruno Haible
Andreas Schwab wrote: > In file included from boot-time.c:47: > readutmp.h:145:16: error: ‘__UT_USERSIZE’ undeclared here (not in a > function); did you mean ‘UT_USER_SIZE’? > 145 | char ut_user[__UT_USERSIZE]; /* Username. */ > |^ > |

Re: boot-time: straighten code

2023-08-14 Thread Andreas Schwab
In file included from boot-time.c:47: readutmp.h:145:16: error: ‘__UT_USERSIZE’ undeclared here (not in a function); did you mean ‘UT_USER_SIZE’? 145 | char ut_user[__UT_USERSIZE]; /* Username. */ |^ |UT_USER_SIZE make[3]: *** [Makef

Re: boot-time: straighten code

2023-08-13 Thread Corwin Brust
On Sun, Aug 13, 2023 at 8:07 PM Po Lu wrote: > > Bruno Haible writes: > > > Po Lu wrote: > >> Both of your patches appear to work. > > > > Thanks for the confirmation. As you know, I'm using a Termux environment > > Regular merges from Gnulib into Emacs should facilitate that, since I've > set as

Re: boot-time: straighten code

2023-08-13 Thread Po Lu
Bruno Haible writes: > Po Lu wrote: >> Both of your patches appear to work. > > Thanks for the confirmation. As you know, I'm using a Termux environment > for testing on Android. This has only approximately, not exactly, the same > include files and libc as what you are using when you compile wit

Re: boot-time: straighten code

2023-08-13 Thread Bruno Haible
Po Lu wrote: > Both of your patches appear to work. Thanks for the confirmation. As you know, I'm using a Termux environment for testing on Android. This has only approximately, not exactly, the same include files and libc as what you are using when you compile with some Android NDK. Therefore I'm

Re: boot-time: straighten code

2023-08-13 Thread Po Lu
Bruno Haible writes: > Po Lu wrote: >> During the automated build of the Android port, the following errors >> were encountered with the Android NDK r10b and __ANDROID_API__ set to 8 >> (which is the oldest configuration Emacs supports.) >> ... >> boot-time.c: In function 'get_boot_time_uncached'

Re: boot-time: straighten code

2023-08-13 Thread Bruno Haible
Po Lu wrote: > During the automated build of the Android port, the following errors > were encountered with the Android NDK r10b and __ANDROID_API__ set to 8 > (which is the oldest configuration Emacs supports.) > ... > boot-time.c: In function 'get_boot_time_uncached': > boot-time.c:111:26: error:

Re: boot-time: straighten code

2023-08-13 Thread Bruno Haible
Po Lu wrote: > During the automated build of the Android port, the following errors > were encountered with the Android NDK r10b and __ANDROID_API__ set to 8 > (which is the oldest configuration Emacs supports.)... > > In file included from boot-time.c:54:0: > boot-time-aux.h: In function 'get_lin

Re: boot-time: straighten code

2023-08-13 Thread Bruno Haible
Po Lu wrote: > During the automated build of the Android port, the following errors > were encountered with the Android NDK r10b and __ANDROID_API__ set to 8 > (which is the oldest configuration Emacs supports.) > ... > boot-time.c:111:26: note: each undeclared identifier is reported only once > f

Re: boot-time: straighten code

2023-08-12 Thread Paul Eggert
On 2023-08-12 20:26, Po Lu wrote: In file included from boot-time.c:54:0: boot-time-aux.h: In function 'get_linux_uptime': boot-time-aux.h:70:3: error: implicit declaration of function 'sysinfo' [-Werror=implicit-function-declaration] if (sysinfo (&info) >= 0) ^ boot-time.c: In function

Re: boot-time: straighten code

2023-08-12 Thread Po Lu
Paul Eggert writes: > On 2023-08-11 14:49, Bruno Haible wrote: >> Paul: With this simplification, you may consider using the 'boot-time' module >> in Emacs. I bet that it produces a better result than Emacs' src/filelock.c >> on many platforms. (I haven't tested it, but I could test it if you giv

Re: boot-time: straighten code

2023-08-12 Thread Paul Eggert
On 2023-08-11 14:49, Bruno Haible wrote: Paul: With this simplification, you may consider using the 'boot-time' module in Emacs. I bet that it produces a better result than Emacs' src/filelock.c on many platforms. (I haven't tested it, but I could test it if you give me a manual testing recipe.)

boot-time: straighten code

2023-08-11 Thread Bruno Haible
This set of patches straightens the code of the 'boot-time' module: Determining the boot time does require iterating through the /var/run/utmpx file, but it does not require - memory allocation, - copying of strings, - evaluating an options parameter, - linking with libsystemd. So, let me