base64-tests (was: Re: base64.c vs. newlines)

2008-01-17 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: >> Note also that I haven't yet updated tests/test-base64.c. >> However, I have added quite a few to coreutils' tests/misc/base64. > > I don't think merging all of these back is important. But I've just > noticed that there is no modules/base64-tests in

Re: base64.c vs. newlines

2008-01-17 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Hi Simon, > > coreutils' `base64 --decode's inability to decode its own encoded > output (without the sledgehammer of --ignore-garbage) finally got > to me :-) Hi Jim! Finally, reviewing this got to me. :-) > So I bit the bullet and changed gnulib's ba

Re: base64.c vs. newlines

2007-01-05 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: >> In the mean time -- sometimes it's easier to review things >> when they're checked in... > > Thanks! I hope to review it soon. Sorry about the delay on this... > I'm still catching up many things after an alm

Re: base64.c vs. newlines

2007-01-04 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > In the mean time -- sometimes it's easier to review things > when they're checked in... Thanks! I hope to review it soon. Sorry about the delay on this... I'm still catching up many things after an almost one-month vacation. /Simon

Re: base64.c vs. newlines

2007-01-04 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > For your reviewing fun, I've included both the gnulib parts > and the coreutils parts: > > [gnulib] > 2007-01-03 Jim Meyering <[EMAIL PROTECTED]> > > When decoding, always allow newlines in input, with almost no > performance impact. > *

base64.c vs. newlines

2007-01-03 Thread Jim Meyering
Hi Simon, coreutils' `base64 --decode's inability to decode its own encoded output (without the sledgehammer of --ignore-garbage) finally got to me :-) So I bit the bullet and changed gnulib's base64.c and coreutils' src/base64.c so they decode embedded newlines unconditionally. I've included th