Re: avoiding obsolete macros like AC_TRY_RUN

2010-08-26 Thread Bruno Haible
On 2010-07-20 I wrote: > > > - Pitfall: It's easy to forget the invocation of AC_LANG_SOURCE, and > > > then > > >autoconf generates code which will fail on many but not all > > > platforms. > > > > We should think about what we can do to address this, thanks for the > > suggestion.

Re: avoiding obsolete macros like AC_TRY_RUN

2010-07-19 Thread Ralf Wildenhues
Hello Bruno, * Bruno Haible wrote on Tue, Jul 20, 2010 at 02:40:06AM CEST: > Coming back to our discussion of AC_TRY_RUN etc. in > [1] > [2] > > I now realized

Re: avoiding obsolete macros like AC_TRY_RUN

2010-07-19 Thread Bruno Haible
Hi Ralf, Coming back to our discussion of AC_TRY_RUN etc. in [1] [2] I now realized that "autoconf -Wall" is giving warnings because of gettext.m4, intl.m4, an

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-10 Thread Ralf Wildenhues
Hello, I have pushed the patch below now, with argp.m4 changes omitted and ChangeLog adjusted, so there's no need to wait for Sergey. Thanks everyone for their reviews! Ralf * Ralf Wildenhues wrote on Fri, Sep 04, 2009 at 08:50:11PM CEST: Remove obsolete macros from several modules.

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-08 Thread Ralf Wildenhues
Hello Sergey, do you mind if I apply this patch which touches a file maintained by you? Thanks, Ralf * Ralf Wildenhues wrote on Fri, Sep 04, 2009 at 08:50:11PM CEST: [...] > Sergey Poznyakoff for > m4/argp.m4 [...] > OK to co

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-07 Thread Paolo Bonzini
Paolo Bonzini for m4/poll.m4 Goes without saying, thanks. Paolo

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-07 Thread Simon Josefsson
Ralf Wildenhues writes: > Simon Josefsson for > m4/gc-camellia.m4 > m4/getaddrinfo.m4 > m4/getline.m4 > m4/readline.m4 > m4/select.m4 > m4/sockets.m4 > m4/socklen.m4 > m4/sockpfaf.m4 > m4/sysexits.m4 > > OK to commit? I welcome this change. I have not tested it manually, but please push it and

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-04 Thread Ben Pfaff
Ralf Wildenhues writes: > Ben Pfaff for > m4/check-math-lib.m4 > m4/isfinite.m4 > m4/round.m4 > m4/roundf.m4 Looks fine. Thank you, Ralf. -- Ben Pfaff http://benpfaff.org

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-04 Thread Jim Meyering
Ralf Wildenhues wrote: > Hello All, esp. Ben, Paolo, Paul, Sergey, Simon, > > the patch below removes obsolete macros from modules not maintained by > Bruno or Jim. > > Special here is check-math-lib.m4:gl_CHECK_MATH_LIB which uses macro > arguments. Is this a public macro? All in-tree users do n

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-04 Thread Ralf Wildenhues
Hello All, esp. Ben, Paolo, Paul, Sergey, Simon, the patch below removes obsolete macros from modules not maintained by Bruno or Jim. Special here is check-math-lib.m4:gl_CHECK_MATH_LIB which uses macro arguments. Is this a public macro? All in-tree users do not mind the change from double-quot

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-04 Thread Ralf Wildenhues
Hello Bruno, * Bruno Haible wrote on Thu, Sep 03, 2009 at 12:59:48AM CEST: > I have three problems with your patch. Four, I would say: ;-) 0) You have been used to the old ways for a decade. This may sound offensive, but isn't meant to be, really. When new users ask questions about quoting on

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-03 Thread Paolo Bonzini
Drawbacks of AC_*_IFELSE: - Unmnemonic naming of the macros. Macros and procedure names should follow the convention of "verb" or "verb_noun", so that they can better be remembered by people who are familiar with English grammar. Well, the common name was already taken

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-02 Thread Bruno Haible
Hi Ralf, > * gnulib-tool (func_create_testdir, func_create_megatestdir): > Replace obsolete Autoconf macros with modern counterparts. This part is undoubtably good. I have applied it for you. For the rest, you would have saved yourself some time by asking whether a patch of this kind is

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-02 Thread Ralf Wildenhues
* Jim Meyering wrote on Wed, Sep 02, 2009 at 09:14:42AM CEST: > You're welcome to apply that. Thanks! > However, please write more in the log, e.g., Taken into account below. * Bruno Haible wrote on Wed, Sep 02, 2009 at 10:12:58AM CEST: > Ralf Wildenhues wrote: > > --- a/m4/getloadavg.m4 > > ++

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-02 Thread Bruno Haible
Ralf Wildenhues wrote: > diff --git a/m4/getloadavg.m4 b/m4/getloadavg.m4 > index 28237d7..e5ea9a4 100644 > --- a/m4/getloadavg.m4 > +++ b/m4/getloadavg.m4 > @@ -174,14 +174,14 @@ AC_CHECK_HEADERS([nlist.h], > `n_un' member. Obsolete, depend on >

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-02 Thread Jim Meyering
Ralf Wildenhues wrote: > * Jim Meyering wrote on Tue, Sep 01, 2009 at 08:19:55AM CEST: >> >> I'd welcome patches to modernize the m4/*.m4 files under my care. >> Since I tend to use gnulib's files as models, it's worthwhile to >> update them to use macros that aren't listed as "obsolete". > > OK, h

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-01 Thread Ralf Wildenhues
* Jim Meyering wrote on Tue, Sep 01, 2009 at 08:19:55AM CEST: > > I'd welcome patches to modernize the m4/*.m4 files under my care. > Since I tend to use gnulib's files as models, it's worthwhile to > update them to use macros that aren't listed as "obsolete". OK, here we go. This patch is for m

avoiding obsolete macros like AC_TRY_RUN [Re: gnulib-izing sharutils

2009-08-31 Thread Jim Meyering
Ralf Wildenhues wrote: > * Bruno Haible wrote on Sun, Aug 30, 2009 at 11:30:53PM CEST: >> > configure.ac:21: warning: The macro `AC_TRY_RUN' is obsolete. >> >> You can ignore these warnings. AC_TRY_RUN and AC_TRY_LINK cannot go away >> because hundreds of autoconf macros use them. > > I'd venture t