Then your function body isn't "dirtied" with #if directives,
True, but system.h is :). In this case, I think I'll go for the
#if ENABLE_NLS, not so much because of the potential for warnings, but
because it is two lines of directives vs. six.
Thanks,
karl
Hello Karl,
* Karl Berry wrote on Thu, Nov 09, 2006 at 01:55:38AM CET:
> In case anyone is not totally bored already, one more time for gettext
> 0.16 (thanks Bruno)...
> ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz)
>
> By the way, a Cygwin user wrote to the Texinfo list, and I ask
Jim,
> I don't see
> how you could be objecting to such an addition to hello's system.h.
It's up to Karl to decide what he puts into hello's system.h. I only mentioned
that these definitions can _in_general_ lead to "unused variable" warnings.
Bruno
Bruno Haible <[EMAIL PROTECTED]> wrote:
> Jim Meyering wrote:
>> Better still, add this in system.h:
>>
>> #if ! ENABLE_NLS
>> # undef textdomain
>> # define textdomain(Domainname) /* empty */
>> # undef bindtextdomain
>> # define bindtextdomain(Domainname, Dirname) /* empty */
Jim Meyering wrote:
> Better still, add this in system.h:
>
> #if ! ENABLE_NLS
> # undef textdomain
> # define textdomain(Domainname) /* empty */
> # undef bindtextdomain
> # define bindtextdomain(Domainname, Dirname) /* empty */
> #endif
If you do this, you'll get "unused
Bruno Haible <[EMAIL PROTECTED]> wrote:
> Paul Eggert wrote:
>> 2. The "#if ENABLE_NLS" isn't needed, since gettext.h does the right
>> thing anyway.
>
>> -#if ENABLE_NLS
>>/* Set the text message domain. */
>>bindtextdomain (PACKAGE, LOCALEDIR);
>>textdomain (PACKAGE);
>> -#endif
Paul Eggert wrote:
> 2. The "#if ENABLE_NLS" isn't needed, since gettext.h does the right
> thing anyway.
> -#if ENABLE_NLS
>/* Set the text message domain. */
>bindtextdomain (PACKAGE, LOCALEDIR);
>textdomain (PACKAGE);
> -#endif
But with this, configuring with "./configure --d
Ben Pfaff wrote:
Matthew Woehlke writes:
Karl Berry wrote:
the gnulib module exit, to ensure the existence of EXIT_SUCCESS.
Isn't it part of some sufficiently-old standard so that it's not
necessary/recommended?
What is "it"? Using EXIT_SUCCESS, using gnulib to ensure that you have
EXIT_*, us
What is "it"? Using EXIT_SUCCESS, using gnulib to ensure that you have
EXIT_*, using EXIT_* in general?
"It" = Using EXIT_SUCCESS without using the gnulib exit module. Isn't
EXIT_SUCCESS part of (or something) for a couple of decades now?
Obviously it's no particular problem to pull in
Matthew Woehlke <[EMAIL PROTECTED]> writes:
> Karl Berry wrote:
>>> the gnulib module exit, to ensure the existence of EXIT_SUCCESS.
>>
>> Isn't it part of some sufficiently-old standard so that it's not
>> necessary/recommended?
>
> What is "it"? Using EXIT_SUCCESS, using gnulib to ensure that yo
Karl Berry wrote:
the gnulib module exit, to ensure the existence of EXIT_SUCCESS.
Isn't it part of some sufficiently-old standard so that it's not
necessary/recommended?
What is "it"? Using EXIT_SUCCESS, using gnulib to ensure that you have
EXIT_*, using EXIT_* in general?
I'm less sure
Attached is a patch for hello.c.
Thanks Eric, that's much cleaner. I installed it.
the gnulib module exit, to ensure the existence of EXIT_SUCCESS.
Isn't it part of some sufficiently-old standard so that it's not
necessary/recommended?
Solaris release that didn't support atexit
A quick review.
Thanks Paul, I installed that.
> ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz)
A quick review.
1. Here's a warning I observed on Solaris 8 with Sun C 5.8:
source='hello.c' object='hello.o' libtool=no \
DEPDIR=.deps depmode=none /bin/bash ../build-aux/depcomp \
cc -xarch=v9 -DLOCALEDIR=\"/usr/loc
Eric Blake wrote:
> 2006-11-09 Eric Blake <[EMAIL PROTECTED]>
>
> * hello.c (main): Use atexit, to avoid warning with 'gcc -Wall
> -Werror'.
> (my_exit): Delete, no longer needed.
>
I support this patch. Using 'atexit' leads to more maintainable code
than pervasive use of 'my
Eric Blake <[EMAIL PROTECTED]> writes:
> + /* Even exiting has subtleties. The /dev/full device on GNU/Linux
> + can be used for testing whether writes are checked properly. For
> + instance, hello >/dev/null should exit unsuccessfully. On exit,
s%dev/null%dev/full%
> + if any wr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Karl Berry on 11/8/2006 5:55 PM:
> In case anyone is not totally bored already, one more time for gettext
> 0.16 (thanks Bruno)...
> ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz)
Alas, it fails to build with 'gcc -Wall -Werr
In case anyone is not totally bored already, one more time for gettext
0.16 (thanks Bruno)...
ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz)
By the way, a Cygwin user wrote to the Texinfo list, and I asked him to
try make check in hello, and he did (in various modes), and all went
wel
Bruce Korb gmail.com> writes:
>
> On 10/16/06, Eric Blake byu.net> wrote:
> > You need to make sure that 'hello --help --version' is different than
> > `hello --version --help'; right now, --help always wins.
>
> As one would rightly expect. You want to be able to append ``--help''
> to what
On 10/16/06, Eric Blake <[EMAIL PROTECTED]> wrote:
You need to make sure that 'hello --help --version' is different than
`hello --version --help'; right now, --help always wins.
As one would rightly expect. You want to be able to append ``--help''
to what you've
typed so far, see the help, and
Karl Berry freefriends.org> writes:
>
> I put another hello pretest at
> ftp://alpha.gnu.org/gnu/hello/hello-2.1.93.tar.bz2 (and .gz).
>
> Besides the various patches, I tried to delete CR characters from the
> program output for the tests. Let me know if it flies ...
I put another hello pretest at
ftp://alpha.gnu.org/gnu/hello/hello-2.1.93.tar.bz2 (and .gz).
Besides the various patches, I tried to delete CR characters from the
program output for the tests. Let me know if it flies ...
Thanks,
Karl
22 matches
Mail list logo
