Re: another dup2 mingw failure

2010-01-12 Thread Simon Josefsson
Eric Blake writes: > That said, here's a review of your proposed patch: Thanks! Here is an updated patch that I will use in my projects. /Simon diff --git a/gltests/dup2.c b/gltests/dup2.c index a4422bf..b9b329c 100644 --- a/gltests/dup2.c +++ b/gltests/dup2.c @@ -40,6 +40,7 @@ rpl_dup2 (int

Re: another dup2 mingw failure

2010-01-11 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 1/9/2010 4:06 AM: >> There is another dup2 failure due to Wine, see: >> >> http://bugs.winehq.org/show_bug.cgi?id=21291 >> >> The patch below works around it. Thoughts? > > Hmm. Repeatedly adding workarounds for wine bugs seems awkward. If

Re: another dup2 mingw failure

2010-01-09 Thread Eric Blake
According to Simon Josefsson on 1/9/2010 4:06 AM: > There is another dup2 failure due to Wine, see: > > http://bugs.winehq.org/show_bug.cgi?id=21291 > > The patch below works around it. Thoughts? Hmm. Repeatedly adding workarounds for wine bugs seems awkward. If the goal is making wine a wind

another dup2 mingw failure

2010-01-09 Thread Simon Josefsson
There is another dup2 failure due to Wine, see: http://bugs.winehq.org/show_bug.cgi?id=21291 The patch below works around it. Thoughts? /Simon 2010-01-09 Simon Josefsson * lib/dup2.c (rpl_dup2): Restore text mode when needed, to work around Wine bug #21291. diff --git a/li