Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-07 Thread Matteo Croce
On Mon, May 7, 2018 at 11:55 AM, Matteo Croce wrote: > On Mon, May 7, 2018 at 4:07 AM, Paul Eggert wrote: >> Bruno Haible wrote: >>> >>> Oops, I goofed with "git diff". Here's the correct patch to test. >> >> >> I tried those bench-md5 benchmarks on two platforms, with somewhat more >> disappoint

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-07 Thread Matteo Croce
On Mon, May 7, 2018 at 4:07 AM, Paul Eggert wrote: > Bruno Haible wrote: >> >> Oops, I goofed with "git diff". Here's the correct patch to test. > > > I tried those bench-md5 benchmarks on two platforms, with somewhat more > disappointing results. > > I observed a real-time slowdown ranging from 1

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Paul Eggert
Bruno Haible wrote: Oops, I goofed with "git diff". Here's the correct patch to test. I tried those bench-md5 benchmarks on two platforms, with somewhat more disappointing results. I observed a real-time slowdown ranging from 11% (large buffers) to 22x (small buffers) on Intel Xeon E3-1225

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Bruno Haible
Matteo Croce wrote: > I have 55efbb1178e045d52b0f52a2160f3d943c4f8a2c but the patch fails to apply. Oops, I goofed with "git diff". Here's the correct patch to test. Bruno diff --git a/lib/md5.c b/lib/md5.c index 9b414aa..69240b3 100644 --- a/lib/md5.c +++ b/lib/md5.c @@ -221,6 +221,14 @@ process

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Matteo Croce
On Sun, May 6, 2018 at 9:00 PM, Bruno Haible wrote: > Hi Matteo, > >> I've checked out latest gnulib, and after double checking that commit >> 761523ddea70f0456b556c09868910686751fff5 was there I ran this: > > Please take commit 55efbb1178e045d52b0f52a2160f3d943c4f8a2c plus the patch > from https:

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Bruno Haible
Hi Matteo, > I've checked out latest gnulib, and after double checking that commit > 761523ddea70f0456b556c09868910686751fff5 was there I ran this: Please take commit 55efbb1178e045d52b0f52a2160f3d943c4f8a2c plus the patch from https://lists.gnu.org/archive/html/bug-gnulib/2018-05/msg00035.html.

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Matteo Croce
On Sun, May 6, 2018 at 6:01 PM, Bruno Haible wrote: > Now, here's a draft patch for adding support for AF_ALG also for the > sha1_buffer etc. functions. > > But I have a problem here: On 4 different systems, I don't get a speedup > from this patch. > > To benchmark it, I use this set of commands:

Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Bruno Haible
Now, here's a draft patch for adding support for AF_ALG also for the sha1_buffer etc. functions. But I have a problem here: On 4 different systems, I don't get a speedup from this patch. To benchmark it, I use this set of commands: $ ./gnulib-tool --create-testdir --dir=testdir --single-configur

af_alg: Add ability to use Linux kernel crypto API on data in memory

2018-05-06 Thread Bruno Haible
dd ability to use Linux kernel crypto API on data in memory. * lib/af_alg.h (afalg_buffer): New declaration. * lib/af_alg.c (afalg_buffer): New function. diff --git a/lib/af_alg.h b/lib/af_alg.h index 45c2c12..018fa22 100644 --- a/lib/af_alg.h +++ b/lib/af_alg.h @@ -37,6 +37,30 @@