Re: acl: refactor error messages in copy-acl.c

2008-06-02 Thread Bruno Haible
Jim Meyering wrote: > > * lib/copy-acl.c (qcopy_acl): New function, extracted from copy_acl. > > (copy_acl): Just a wrapper around qcopy_acl that emits the error > > messages. > > Obviously an improvement, and looks correct. > Go ahead. Thanks! Applied, together with a corresponding

Re: acl: refactor error messages in copy-acl.c

2008-06-02 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > After adding support for all platforms, copy-acl.c contains 7 times the error > message regarding the source file, and 11 times the error message regarding > the destination file. This begs for refactoring. Doing this refactoring > ahead of the other change

acl: refactor error messages in copy-acl.c

2008-06-01 Thread Bruno Haible
Hi Jim, After adding support for all platforms, copy-acl.c contains 7 times the error message regarding the source file, and 11 times the error message regarding the destination file. This begs for refactoring. Doing this refactoring ahead of the other changes will make these changes simpler. OK?