Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-27 Thread Allison Karlitskaya
Great! Thanks so much for dealing with this so rapidly! Allison On Tue, 27 Aug 2024 at 11:49, Bruno Haible wrote: > Allison Karlitskaya wrote: > > I can confirm that with this patch, the output of `who` shows Cockpit > > again. Specifically: > > > > admincockpit 2024-08-27 08:21

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-27 Thread Bruno Haible
Allison Karlitskaya wrote: > I can confirm that with this patch, the output of `who` shows Cockpit > again. Specifically: > > admincockpit 2024-08-27 08:21 (:::172.27.0.2) Thanks, that's perfect. I'm committing the patch: 2024-08-27 Bruno Haible readutmp: In system

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-27 Thread Allison Karlitskaya
hi Bruno, Thanks for the quick turnaround! I can confirm that with this patch, the output of `who` shows Cockpit again. Specifically: admincockpit 2024-08-27 08:21 (:::172.27.0.2) Thanks! Allison On Mon, 26 Aug 2024 at 23:58, Bruno Haible wrote: > Hi Allison, > > Based on

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-26 Thread Bruno Haible
Hi Allison, Based on the files named '3' and '4' in data-after.tar.gz, I believe the attached change (not yet committed) has good chances of working. Can you please give it a try? Bruno diff --git a/lib/readutmp.c b/lib/readutmp.c index 10d79d1d81..3c4f97b146 100644 --- a/lib/readutmp.c +++ b/li

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-26 Thread Allison Karlitskaya
hi, Please see attached :) Allison On Mon, 26 Aug 2024 at 16:47, Bruno Haible wrote: > Allison Karlitskaya wrote: > > This impacts the output of the "who" command when someone is logged in > via > > Cockpit. The old version printed: > > > > adminweb console 2024-08-26 08:46 (:::1

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-26 Thread Bruno Haible
Allison Karlitskaya wrote: > This impacts the output of the "who" command when someone is logged in via > Cockpit. The old version printed: > > adminweb console 2024-08-26 08:46 (:::172.27.0.2) > > and the new version simply doesn't list the login. The goal of the new readutmp impl

Re: tty heuristics in lib/readutmp.c exclude "web" sessions

2024-08-26 Thread Paul Eggert
On 2024-08-26 01:51, Allison Karlitskaya wrote: So I guess my wish here is open-ended, but something like "please allow for a way to ensure that web logins appear in the output of who" If we're simply trying to emulate the old readutmp it sounds like this should be the default behavior.