Re: error, verror: Don't call va_end twice.

Collin Funk wrote: > Sure. Reported here [1]. And patch here [2]. > > Collin > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=32233 > [2] https://sourceware.org/pipermail/libc-alpha/2024-October/160366.html Thanks! And I reported another one: https://sourceware.org/bugzilla/show_bug.cgi?

Re: error, verror: Don't call va_end twice.

Hi Bruno, Bruno Haible writes: > AFAICS, glibc has this bug already since 2001. Can you please file a glibc > bug for it? Sure. Reported here [1]. And patch here [2]. Collin [1] https://sourceware.org/bugzilla/show_bug.cgi?id=32233 [2] https://sourceware.org/pipermail/libc-alpha/2024-October/

Re: error, verror: Don't call va_end twice.

Collin Funk wrote: > I noticed that verror/error call va_end twice. Once in error_tail and > then again in the calling function. Thanks! Yes, it is wrong to invoke va_end (args); inside error_tail, because ISO C 23 § 7.16.1 says (emphasis is mine): "Each invocation of the va_start and va_cop