Re: Patch: Fix OS X PowerPC support

2025-04-28 Thread Sevan Janiyan
On 28/04/2025 18:13, Bruno Haible wrote: Sevan Janiyan wrote: Just as a heads up, the issue is not exclusive to 10.4 on PowerPC. The issue is that on 10.4, period. I hit the same issue on 10.4 on Intel. Then we might need a similar patch for lib/sigsegv.c lines 663 and 671 ? I'll take a look

Re: Patch: Fix OS X PowerPC support

2025-04-28 Thread Bruno Haible via Gnulib discussion list
Sevan Janiyan wrote: > Just as a heads up, the issue is not exclusive to 10.4 on PowerPC. The > issue is that on 10.4, period. I hit the same issue on 10.4 on Intel. Then we might need a similar patch for lib/sigsegv.c lines 663 and 671 ? > It seems that the kernel just lacks the functionality.

Re: Patch: Fix OS X PowerPC support

2025-04-28 Thread Sevan Janiyan
Hi Bruno, On 28/04/2025 17:07, Bruno Haible wrote: Thanks for the effort. Actually, I committed a patch from Evan Miller that should fix the issue, without complicated MacOS X version deliberations: https://gitweb.git.savannah.gnu.org/gitweb/? p=gnulib.git;a=commitdiff;h=cdddbed4e8745a1130cd395

Re: Patch: Fix OS X PowerPC support

2025-04-28 Thread Bruno Haible via Gnulib discussion list
Hi. Sevan Janiyan wrote on 2023-11-14: > > If so, can you change your patch so that > >1) it is symmetric w.r.t. to MIN and MAX, > > and/or > >2) it at least compiles for a range that includes both 10.4 and 10.5, > > and ideally works on 10.5? I think that would be the best behaviour

Re: Patch: Fix OS X PowerPC support

2024-10-20 Thread Sevan Janiyan
On 14/11/2023 20:41, Sevan Janiyan wrote: Ok, I reworked the patch so that it only relies on MAC_OS_X_VERSION_MAX_ALLOWED to set SIGSEGV_FAULT_STACKPOINTER on 10.4 & older. It falls through on the else case to set things up on 10.5. Tested results as follows: builds on tiger with just ./config

Re: Patch: Fix OS X PowerPC support

2023-11-14 Thread Sevan Janiyan
On 14/11/2023 18:42, Bruno Haible wrote: I can't find the time to think through the detailed results that you listed. I hope you can do that. No worries, hopefully I wont end up being to much of a bother. But in summary, my point was "the patch is odd, because it uses MIN in one place and MAX

Re: Patch: Fix OS X PowerPC support

2023-11-14 Thread Bruno Haible
Sevan Janiyan wrote: > On 10/11/2023 02:41, Sevan Janiyan wrote: > > On 09/11/2023 23:48, Bruno Haible wrote: > >> The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and > >> MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles > >> for a range that includes both 10.4 a

Re: Patch: Fix OS X PowerPC support

2023-11-14 Thread Sevan Janiyan
On 10/11/2023 02:41, Sevan Janiyan wrote: On 09/11/2023 23:48, Bruno Haible wrote: The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles for a range that includes both 10.4 and 10.5? That is,    MAC_OS_X_VERSION_M

Re: Patch: Fix OS X PowerPC support

2023-11-09 Thread Sevan Janiyan
On 09/11/2023 23:48, Bruno Haible wrote: The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles for a range that includes both 10.4 and 10.5? That is, MAC_OS_X_VERSION_MIN_REQUIRED is MAC_OS_X_VERSION_10_4 and

Re: Patch: Fix OS X PowerPC support

2023-11-09 Thread Bruno Haible
Sevan Janiyan wrote: > @@ -676,11 +678,21 @@ int libsigsegv_version = LIBSIGSEGV_VERSION; > > # elif defined __powerpc__ > > +#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 > /* See the definitions of > - 'ucontext_t' and 'struct __darwin_ucontext' in , > - 'struct __d

Re: Patch: Fix OS X PowerPC support

2023-11-09 Thread Bruno Haible
Sevan Janiyan wrote: > On 30/11/2021 01:12, Bruno Haible wrote: > > I suspect that it merely compiles, but does not actually work on Mac > > OS X 10.4.x. > > > > You can find out by running "make check", to see whether the unit > > tests pass. > > > Running "make check" results in 2 test failure

Re: Patch: Fix OS X PowerPC support

2023-11-09 Thread Sevan Janiyan
On 06/11/2023 13:54, Sevan Janiyan wrote: Sorry about the noise, I suspect the patch is invalid for Leopard. I will follow up with a new patch which splits the case for 10.5 & older, if that is the case, once I've done more testing. Attached patch splits the powerpc case to Leopard and newer (

Re: Patch: Fix OS X PowerPC support

2023-11-06 Thread Sevan Janiyan
On 06/11/2023 03:09, Sevan Janiyan wrote: Updated version of the patch attached. Sorry about the noise, I suspect the patch is invalid for Leopard. I will follow up with a new patch which splits the case for 10.5 & older, if that is the case, once I've done more testing. Sevan

Re: Patch: Fix OS X PowerPC support

2023-11-05 Thread Sevan Janiyan
On 30/11/2021 01:12, Bruno Haible wrote: I suspect that it merely compiles, but does not actually work on Mac OS X 10.4.x. You can find out by running "make check", to see whether the unit tests pass. Running "make check" results in 2 test failures without the use of libsigsegv. ./../build

Re: Patch: Fix OS X PowerPC support

2021-11-29 Thread Bruno Haible
Hello Sevan, > Attached patch fixes support for building lib/sigsegv.c in PowerPC Mac > OS X. Tested on OS X 10.4.11. > > Amended definition sources in comment using > https://opensource.apple.com/source/xnu/xnu-792.24.17/bsd/sys/_types.h.auto.html > https://opensource.apple.com/source/xnu/xnu-7