Re: [bug-gnulib] Re: FYI, utimens was missing a dependency on timespec

2007-03-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 2/28/2007 4:37 PM: > The two modules 'utimens' and 'utimecmp' still fail to build even on glibc > systems, according to http://autobuild.josefsson.org/gnulib/. > > Here's a proposed fix: > > > 2007-02-28 Bruno Haible <

Re: [bug-gnulib] Re: FYI, utimens was missing a dependency on timespec

2007-02-28 Thread Bruno Haible
Eric Blake wrote: > 2007-02-23 Eric Blake <[EMAIL PROTECTED]> > > * lib/getdate.h (includes): Include , not "timespec.h". > * lib/stat-time.h (includes): Likewise. > * lib/utimecmp.c (includes): Likewise. > * lib/utimens.h (includes): Likewise. > * lib/getdate.y (i

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > 2007-02-23 Eric Blake <[EMAIL PROTECTED]> > > * lib/getdate.h (includes): Include , not "timespec.h". > * lib/stat-time.h (includes): Likewise. > * lib/utimecmp.c (includes): Likewise. > * lib/utimens.h (includes): Likewise. >

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
Jim Meyering meyering.net> writes: > No. Otherwise, gnulib's "time.h" replacement becomes mandatory, > and encourages gnulib-using applications to use functions > that are not standard. Agreed. > > > Or do we keep the timespec module, which both coreutils and tar > > explicitly request, as an

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > Jim Meyering meyering.net> writes: > >> >> There is a declaration of struct timespec in time_.h, >> so utimens.h, stat-time.h, and getdate.h should include >> rather than timespec.h. Then timespec.h can be removed. >> >> I'll look into that over the weeke

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
Jim Meyering meyering.net> writes: > > There is a declaration of struct timespec in time_.h, > so utimens.h, stat-time.h, and getdate.h should include > rather than timespec.h. Then timespec.h can be removed. > > I'll look into that over the weekend, if no one else does it first. I took a cl

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 2/22/2007 2:26 PM: >> This fixes it: >> >> * modules/utimens (Depends-on): Add timespec, required for >> utimens.h's inclusion of timespec.h. > > stat-time is another module that uses raw timespec.h without depending on

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 2/22/2007 2:26 PM: > This fixes it: > > * modules/utimens (Depends-on): Add timespec, required for > utimens.h's inclusion of timespec.h. stat-time is another module that uses raw timespec.h without depending