Re: [master b3cf281] Unbreak the MinGW build

2016-12-17 Thread Bruno Haible
Eli Zaretskii wrote: > You can now remove the workaround from stdio-impl.h. Done. Thanks for the rapid debugging. This is the kind of bug that you typically cannot reproduce any more after two weeks, if you don't handle it quickly. Bruno

Re: [master b3cf281] Unbreak the MinGW build

2016-12-17 Thread Eli Zaretskii
> Date: Sat, 17 Dec 2016 09:51:15 +0200 > From: Eli Zaretskii > Cc: bug-gnulib@gnu.org, emacs-de...@gnu.org > > I will try to look into this some more today, and see if I can unlock > the mystery. It bothers me, too. Bug squashed, see commit 0757b4f. It was always there, we were just lucky unt

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-gnulib@gnu.org > Date: Sat, 17 Dec 2016 00:17:31 +0100 > > Since, as you say, the crash occurs during dumping, this is what I would > turn to now. Do you have a systematic approach for debugging crashes during > dump? If dump is based on malloc, does it help to set

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Paul Eggert
Bruno Haible wrote: gnulib has a way to keep in your project changes relative to gnulib that should not be pushed upstream I'd rather not do that, as the Emacs build procedure is already too complicated.

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Bruno Haible
Eli Zaretskii wrote: > > - How often have you tried to temacs+dump with and without the change? > > Once each? Twice each? 10 times each? If it's a small number, you may > > be seeing a random result and not realize it was random. > > I did it in two separate branches, 3 times in each one. Th

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-gnulib@gnu.org, Paul Eggert , emacs-de...@gnu.org > Date: Fri, 16 Dec 2016 19:11:31 +0100 > > On mingw, the fpending.o generated by this code, with or without this > #include , is identical (even with debugging information [-g]). Yes, I said that much. Which is wh

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Bruno Haible
Eli Zaretskii wrote: > > I needed this commit to prevent temacs from crashing during dumping. > > Don't ask me how including errno.h (both the one from Gnulib and the > > MinGW one) could cause this, especially as the preprocessed __fpending > > doesn't seem to change a bit as result of that, and i

Re: [master b3cf281] Unbreak the MinGW build

2016-12-16 Thread Paul Eggert
Eli Zaretskii wrote: I needed this commit to prevent temacs from crashing during dumping. Don't ask me how including errno.h (both the one from Gnulib and the MinGW one) could cause this, especially as the preprocessed __fpending doesn't seem to change a bit as result of that, and it doesn't see