Martin Lambers wrote:
> > The function from libgcc.a is maybe not correct in all
> > situations (think of 64-bit Windows), therefore I would use the
> > replacement also on mingw.
>
> OK, I attached a patch.
Thanks. I applied your patch, adding a lib/getpagesize.c file ("git diff"
omits added fi
Bruno Haible wrote:
> > Do you want to replace the getpagesize function from libgcc.a on MinGW
> > with the implementation above? Or do you want the implementation above
> > only for native Windows variants that don't have getpagesize?
>
> The former. The function from libgcc.a is maybe not correct
Martin Lambers wrote:
> Do you want to replace the getpagesize function from libgcc.a on MinGW
> with the implementation above? Or do you want the implementation above
> only for native Windows variants that don't have getpagesize?
The former. The function from libgcc.a is maybe not correct in al
On Tue, 04. Dec 2007, 09:45:02 +0100, Bruno Haible wrote:
> > > The implementation that you gave in your previous patch
> > >
> > > #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
> > >SYSTEM_INFO system_info;
> > >GetSystemInfo (&system_info);
> > >return system_inf
Martin Lambers wrote:
> It seems to be only in libgcc.a, both in MinGW-5.1.3+MSYS and
> Debian-crosscompiled (version 3.4.5.20060117.1.dfsg-2 from etch).
Indeed! The libgcc.a contains a file _trampoline.o that was compiled from
this piece of gcc-3.4.4/gcc/libgcc2.c:
--
Bruno Haible <[EMAIL PROTECTED]> wrote:
> Martin Lambers wrote on 2007-11-28:
>> MinGW has a getpagesize() function, but does not declare it.
...
Hi Bruno,
Thanks for dealing with this.
I've been distracted with coreutils, recently.
On Mon, Dec 03, 2007 at 12:39:15PM +0100, Bruno Haible wrote:
> > MinGW has a getpagesize() function, but does not declare it.
>
> Strange. The mingw system I have access to does not have a getpagesize()
> function. In yours, in which library is it defined? And what is your mingw
> system? MSYS, C
Martin Lambers wrote on 2007-11-28:
> MinGW has a getpagesize() function, but does not declare it.
Strange. The mingw system I have access to does not have a getpagesize()
function. In yours, in which library is it defined? And what is your mingw
system? MSYS, Cygwin-crosscompiled, or Debian-cross
Martin Lambers wrote on 2007-11-28:
> I attached an updated patch. It now only does the following:
>
> - Do not provide getpagesize.h; modify gnulibs unistd.h instead.
> - Provide a getpagesize declaration if the system does not provide one
> (needed on MinGW).
Thanks. The first part is undoubt
On Tue, 27. Nov 2007, 18:38:13 +0100, Bruno Haible wrote:
> Martin Lambers wrote:
> > If a macro is used instead, should its definition go into
> > lib/unistd.h.in directly, or should it stay in a separate
> > lib/getpagesize.h, which is then included in lib/unistd.h.in?
>
> It should go into lib/
Martin Lambers wrote:
> If a macro is used instead, should its definition go into
> lib/unistd.h.in directly, or should it stay in a separate
> lib/getpagesize.h, which is then included in lib/unistd.h.in?
It should go into lib/unistd.in.h. You can use blank lines or other kinds
of separator lines
On Tue, Nov 27, 2007 at 02:05:06PM +0100, Bruno Haible wrote:
> > - Provide a getpagesize function (not a macro) if the system does not
> > have one.
>
> What is the point of doing that? A function that in most cases just returns
> a fixed number can well be inlined. And since 'inline' is a bit
Hello Martin,
Thanks for your patch.
> - Don't provide a getpagesize.h header. Modify gnulibs unistd.h
> instead.
Yes, I agree this is useful, because although POSIX does not specify
getpagesize() any more, SUSV2 had it declared in [1].
> - Provide a getpagesize function (not a macro) if the
Hi everyone,
MinGW has a getpagesize() function, but does not declare it.
I attached a patch for the getpagesize module. It does the following:
- Don't provide a getpagesize.h header. Modify gnulibs unistd.h
instead.
- Provide a getpagesize declaration if the system does not provid
14 matches
Mail list logo
