Re: NetBSD utimens, utimensat, etc. failures

2024-05-20 Thread Bruno Haible
Hi Collin, > Done in the two attached patches. Thanks a lot! > It looks like you added the UTIME_OMIT ctime bug to the documentation > in this commit: > > commit e6c7f8be2fe11e72c3fff2503be9ab3f798b787a > Author: Bruno Haible > Date: Sat Jul 25 23:27:40 2020 +0200 > > doc: Updat

Re: NetBSD utimens, utimensat, etc. failures

2024-05-20 Thread Collin Funk
Hi Bruno, On 5/20/24 3:54 AM, Bruno Haible wrote: >> I'll leave it for review. > > Looks good to me. Just please change the #if conditions to not test the > *values* of __linux__, __sun, __NetBSD__. That is, the proper way to test > for Linux, Solaris, NetBSD is > defined __linux__ > defined

Re: NetBSD utimens, utimensat, etc. failures

2024-05-20 Thread Bruno Haible
Hi Collin, > This patch fixes all the failures in my NetBSD virtual machine. > > Essentially, NetBSD 10.0 has the same issues as Linux 2.6 hppa had for > this code. Great! I'm glad that you could do it by just combining existing workarounds. > I'll leave it for review. Looks good to me. Just p

Re: NetBSD utimens, utimensat, etc. failures

2024-05-19 Thread Collin Funk
On 5/19/24 2:29 AM, Collin Funk wrote: > With that those two test cases seem to fail for the same reason as the > others: > > $ ./gltests/test-fdutimensat > test-utimens.h:149: assertion 'ctime_compare (&st3, &st2) < 0' failed > $ ./gltests/test-utimensat > test-utimens.h:149:

NetBSD utimens, utimensat, etc. failures

2024-05-19 Thread Collin Funk
Hi Bruno, On your NetBSD test failures you had these: > FAIL: test-fdutimensat > == > > ../../gltests/test-utimens.h:75: assertion 'func (BASE "file", ts) == -1' > failed > FAIL test-fdutimensat (exit status: 134) > > FAIL: test-futimens > === > > ../../gltest