bootstrap: Support a tag name as GNULIB_REVISION

2025-01-09 Thread Bruno Haible via Gnulib discussion list
The 'bootstrap' code, so far, supports as GNULIB_REVISION a commit id or a branch name. This commit adds support for GNULIB_REVISION being a tag name. So as to - make 'bootstrap' a bit more future-proof, - make the "shallow git clone" logic reusable in other

[PATCH] maintainer-makefile: Silence announce-gen error with GNULIB_REVISION.

2024-05-12 Thread Simon Josefsson via Gnulib discussion list
er-makefile: Silence announce-gen error with GNULIB_REVISION. * top/maint.mk (gnulib-version): Silence git describe on failure. --- ChangeLog| 5 + top/maint.mk | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 2e2311e7b2..b6aa21d7f7 100644 -

Re: GNULIB_REVISION

2024-04-25 Thread Paul Eggert
On 4/25/24 10:43, Simon Josefsson wrote: https://gitlab.com/gsasl/inetutils/-/jobs/6706396721 That's an malloc failure on the server side. The savannah admins should be told about the issue soon after it happens. Routine clones of GNU projects shouldn't fail like that. (It's never happened t

Re: GNULIB_REVISION

2024-04-25 Thread Collin Funk
On 4/25/24 10:00 AM, Paul Eggert wrote: > Is there some way to cajole 'git clone' into using less memory, with a > '--depth 1' or similar options? Cloning shallowly would clone Gnulib a > lot faster, if you're cloning from a remote repository. Maybe '--single-branch' would help too. If space is re

Re: GNULIB_REVISION

2024-04-25 Thread Simon Josefsson via Gnulib discussion list
Paul Eggert writes: > You raise several good points. A couple of quick reaction: > > On 2024-04-25 09:26, Simon Josefsson via Gnulib discussion list wrote: > >> - the gnulib git submodule is huge. Not rarely I get out of memory >>errors during 'git clone' in CI/CD jobs. > > First I've heard

Re: GNULIB_REVISION

2024-04-25 Thread Paul Eggert
You raise several good points. A couple of quick reaction: On 2024-04-25 09:26, Simon Josefsson via Gnulib discussion list wrote: - the gnulib git submodule is huge. Not rarely I get out of memory errors during 'git clone' in CI/CD jobs. First I've heard of this problem (other than with G

Re: GNULIB_REVISION

2024-04-25 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Hi Simon, > >> you can ... via >> GNULIB_REVISION pick out exactly the gnulib git revision that libpaper >> needs. ... >> [1] >> https://blog.josefsson.org/2024/04/13/reproducible-and-minimal-source-only-tarballs/ >> [2] https:/

Re: GNULIB_REVISION

2024-04-25 Thread Bruno Haible
Hi Simon, > you can ... via > GNULIB_REVISION pick out exactly the gnulib git revision that libpaper > needs. ... > [1] > https://blog.josefsson.org/2024/04/13/reproducible-and-minimal-source-only-tarballs/ > [2] https://salsa.debian.org/auth-team/libntlm/-/tree/ma

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
Simon Josefsson wrote: > Alas, GNULIB_REVISION is not documented in doc/gnulib.texi. Yes, that's because the more modern way is to use a git submodule instead. This is documented in https://www.gnu.org/software/gnulib/manual/html_node/VCS-Issues.html https://www.gnu.org/software/gnuli

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
, both pointing to the same gnulib > .git work tree. I think the path indicated by --gnulib-srcdir should be > read-only. If --gnulib-srcdir is given and GNULIB_REVISION is set in bootstrap.conf: * The current behaviour (now independent of submodule or not) is that - Without --no-gi

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
ring such an old version, now an error message is output. * 0002 implements prepare_GNULIB_SRCDIR as documented. The real change is that instead of having a single occurrence of git checkout "$GNULIB_REVISION" at the end, we have one in each possible case. Which allows to tailor

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
vironment variable or via the --gnulib-srcdir option), then sources >are fetched from that local directory. If it is a git repository and >the configuration variable GNULIB_REVISION is set in bootstrap.conf, >then that revision is checked out. This piece of documentation is

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
set (either as an >environment variable or via the --gnulib-srcdir option), then sources >are fetched from that local directory. If it is a git repository and >the configuration variable GNULIB_REVISION is set in bootstrap.conf, >then that revision is checked out. > &g

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
> >> git clone --reference "$GNULIB_SRCDIR" "$gnulib_path" \ >> && git checkout -C "$gnulib_path" $GNULIB_REVISION >> GNULIB_SRCDIR="$gnulib_path" >> >> Discussion before suggesting patches would be useful, to

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Bruno Haible
, both pointing to the same gnulib > .git work tree. I think the path indicated by --gnulib-srcdir should be > read-only. > > Should the 'git checkout' code be replaced with something like > > git clone --reference "$GNULIB_SRCDIR" "$gnulib_pat

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Paul Eggert
My quick reaction is that you've identified two bugs. --gnulib-srcdir should only read from that directory, and GNULIB_REVISION should work in bootstrap.conf.

./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
Hi I'm trying to get ./bootstrap from a minimal source-only archive generated via 'git archive' that has GNULIB_REVISION set in bootstrap.conf, expecting this to work: ./bootstrap --gnulib-srcdir=/home/jas/src/gnulib Bug #1: it seems GNULIB_REVISION in bootstrap.conf has no e