Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-14 Thread Joel E. Denny
On Mon, 12 Apr 2010, Petr Machata wrote: > The instructions that you gave indeed do reproduce the problem. Thanks for confirming. > P.S. I seriously wonder whether it's worth it to hunt this esoteric bug. > (Especially given that it was confirmed that the code is written > correctly.) As I sai

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-12 Thread Petr Machata
11.04.2010 20:40, Joel E. Denny wrote: > On Sun, 11 Apr 2010, Bruno Haible wrote: > >> The code in bison-2.4.2/src/output.c looks fine. > > Thanks for confirming. > >> Can you help reproducing or debugging it, with just 2 executables: bison >> and m4? (I.e. give a "how to reproduce" that does no

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-12 Thread Petr Machata
10.04.2010 21:49, Joel E. Denny wrote: > Before switching to create_pipe_bidi, I had observed a race condition. > That is, I could run a test for this problem on the same system many times > in a row, and it would fail only some of the time. This race condition > might still be there. Well, d

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
On Sun, 11 Apr 2010, Bruno Haible wrote: > The code in bison-2.4.2/src/output.c looks fine. Thanks for confirming. > Can you help reproducing or debugging it, with just 2 executables: bison > and m4? (I.e. give a "how to reproduce" that does not involve bison's > testsuite? I'm not inclined to l

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Bruno Haible
Hi Joel, > In the create_pipe_bidi invocation above, I set the slave_process argument > to true. create_pipe_bidi passes that argument to create_pipe, which then > invokes register_slave_subprocess, which uses atexit to register a > function that invokes kill. > > Moreover the documentation i

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
Hi Bruno, On Sun, 11 Apr 2010, Bruno Haible wrote: > > pid = create_pipe_bidi ("m4", m4, (char **)(void*)argv, false, true, > > true, filter_fd); > > I thought that create_pipe_bidi is supposed to make sure > > that the m4 subprocess is killed when Bison invokes exi

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Bruno Haible
Hi Joel, Joel E. Denny wrote: > > input.y: fatal error: too many arguments for @output directive in skeleton > > +/usr/bin/m4:./skel.c:175: ERROR: copying inserted file: Broken pipe > > +/usr/bin/m4: write error > > Thanks for the report. One of the goals of Bison 2.4.2 was to avoid m4's > rep

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
I'm adding bug-gnulib in case they have already seen this problem with create_pipe_bidi. On Fri, 9 Apr 2010, Petr Machata wrote: > I was rebasing the bison package to latest stable (2.4.2) in Fedora > distribution, and found out that the test case 67 fails. I'm attaching > testfile.log. Here's