Simon,
You are welcome to commit your siginterrupt module as proposed on
2009-08-17.
Eric Blake wrote:
> Just because a module is present doesn't mean I have to
> use it; so I am not opposed to adding the module now that
> others have expressed interest in it
Bruno
Or is it something that can only be detected with valgrind?
Only valgrind, because the second sigaction will also fail and -1 will
be returned.
Paolo
?
Or is it something that can only be detected with valgrind?
Also, should we try to give feedback to the POSIX folks
suggesting how they can beef up their samples?
--
Eric Blake
--
View this message in context:
http://www.nabble.com/Re%3A-Buildreport-for-GnuTLS-2.8.3-tp25008027p25015880.html
Sent from the Gnulib mailing list archive at Nabble.com.
Eric Blake wrote:
> If others agree that adding this crutch is worthwhile
Yes, I'm in favour of this new module. 'siginterrupt' was already
considered obsolete in 1993 or so, as I remember from discussions with
H.J. Lu at that time. But Simon's module is so clear, small, self-contained,
that I see
On 08/17/2009 05:57 PM, Simon Josefsson wrote:
Eric Blake writes:
It fails to build on IRIX 5.3 due to missing siginterrupt function:
ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by
tests.o.
Since gnulib does not provide a siginterrupt replacement I instead added
the
Eric Blake writes:
>> > It fails to build on IRIX 5.3 due to missing siginterrupt function:
>> > ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by
>> > tests.o.
>> >
>> > Since gnulib does not provide a siginterrupt replacement I instead added
>> > the replacement used by b
+int
+siginterrupt (int sig, int flag)
+{
+ struct sigaction act;
+
+ if (sigaction (sig, NULL,&act)< 0)
+return -1;
POSIX ignores sigaction failure here, rather than returning -1.
In practice the only difference is that for EINVAL the POSIX version
will cause spurious valgrind failur
hing else with your patch looked okay to me.
--
Eric Blake
--
View this message in context:
http://www.nabble.com/Re%3A-Buildreport-for-GnuTLS-2.8.3-tp25008027p25008955.html
Sent from the Gnulib mailing list archive at Nabble.com.
"Tom G. Christensen" writes:
> It fails to build on IRIX 5.3 due to missing siginterrupt function:
> ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by
> tests.o.
>
> Since gnulib does not provide a siginterrupt replacement I instead added
> the replacement used by bash 4.0
